build: PYTHON ?= python3 #25759

cclauss · 2019-01-28T12:00:50Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

gengjiawen · 2019-01-28T12:24:43Z

There many thing need to fix in tools\test.py like dict.keys.

thefourtheye · 2019-01-28T13:52:13Z

I don't think we are there yet. If we have to switch to Python 3 here, we need to get the word out and explicitly mention this in our requirements to build.

cclauss · 2019-01-28T14:00:45Z

338 days until Python 2 end of life... Perhaps we need to get the word out. #25766

addaleax

I don't think we are there yet. If we have to switch to Python 3 here, we need to get the word out and explicitly mention this in our requirements to build.

Is that an issue, assuming that we still have Python 2 builds in our CI?

I’m wondering whether this should be labelled semver-major, though.

thefourtheye · 2019-01-28T14:12:03Z

Is that an issue, assuming that we still have Python 2 builds in our CI?

As of now, only one of our build machines is using Python 3 (that too kind of experimental, @refack please correct me if I am wrong here), rest of them are still using Python 2 and most of them don't have Python 3.

I’m wondering whether this should be labelled semver-major, though.

I also thought the same. If we do this as part of a major release, people might not miss to notice this important change.

As recommended at nodejs#25759 (comment) * Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan * Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update * Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus

thefourtheye · 2019-01-28T14:16:56Z

338 days until Python 2 end of life... Perhaps we need to get the word out.

I understand that we are racing against the clock here, but we wouldn't want to break people's build infrastructure without proper notice. I believe our first step would be to make all the Python modules compatible with Python 3 and then have all our linters use both Python 2 and Python 3. Once we achieve that we can think about totally dropping Python 2 support, I believe.

gengjiawen · 2019-01-28T14:22:37Z

Currently the code is not fully python3 compatible yet.

thefourtheye · 2019-01-28T14:26:50Z

There many thing need to fix in tools\test.py like dict.keys.

@gengjiawen I have a PR now to fix them #25767.

addaleax · 2019-01-28T14:31:58Z

Actually, @cclauss, can you update the commit message to start with build: rather than test: makefile:?

refack · 2019-01-28T16:48:36Z

FYI, ./configure overrides the default var PYTHON ?= in config.mk, via:

node/Makefile

Line 1 in 4814987

-include config.mk

with

node/configure

Lines 16 to 17 in 4814987

    
           if sys.version_info[0] != 2 or sys.version_info[1] not in (6, 7): 
        
             sys.stderr.write('Please use either Python 2.6 or 2.7')

and

node/configure.py

Lines 1658 to 1662 in 4814987

    
           config = { 
        
             'BUILDTYPE': 'Debug' if options.debug else 'Release', 
        
             'PYTHON': sys.executable, 
        
             'NODE_TARGET_TYPE': variables['node_target_type'], 
        
           }

So this change is mostly symbolic... (it only affects vanilla repositories, when using a target that does not depend on all or $(NODE_EXE), or when called with python3 configure.py)

cclauss · 2019-01-28T17:56:07Z

@refack But this change does effect Travis --> Jenkins automated builds because there is no config.mk in this repo and node/configure does not get run. Thus in the automated CI builds we get tools/cpp_lint.py complaining about Python 3 compatibility --> #25760

refack · 2019-01-28T18:04:09Z

But this change does effect Travis --> Jenkins

Yes, but AFAICT only for the lint jobs (they don't try to build, hence don't call configure).
BTW that Travis fail did raise incompatibilities in tools/cpplint.py that I'm looking at now.

cclauss · 2019-01-28T20:21:42Z

flake8 is passing on both Py2 and Py3 and with #25771, cpp_lint.py should be in the same boat. Are there other linters in the build that rely on Python?

refack · 2019-01-29T00:03:19Z

Are there other linters in the build that rely on Python?

I tested and make lint PYTHON=python3 works as a whole after #25771.

gengjiawen · 2019-01-29T01:45:18Z

Also we need to make windows ready for Python3. https://github.com/nodejs/node/blob/master/tools/msvs/find_python.cmd.

cc @refack @cclauss

As recommended at #25759 (comment) * Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan * Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update * Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus PR-URL: #25766 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

refack · 2019-02-01T14:04:02Z

DI: https://ci.nodejs.org/job/node-test-pull-request/20509/

refack · 2019-02-01T14:05:16Z

Also we need to make windows ready for Python3. /tools/msvs/find_python.cmd@master.

Refs: #25789
I'll make sure that's done when the tree is ready for python3.

addaleax · 2019-02-09T16:25:58Z

Fresh CI: https://ci.nodejs.org/job/node-test-pull-request/20691/

addaleax · 2019-02-17T17:52:26Z

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20837/

addaleax · 2019-02-17T18:11:58Z

Looks like this still needs support from the build WG?

cclauss · 2019-02-17T18:21:52Z

Blocked by nodejs/build#1674

cclauss · 2019-07-05T10:16:20Z

Closing in favor of #28537

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 28, 2019

cclauss mentioned this pull request Jan 28, 2019

tools: need to upgrade tools/cpp_lint.py to be Python 3 compatible #25760

Closed

cclauss force-pushed the patch-1 branch 2 times, most recently from 84aafbb to 243eff0 Compare January 28, 2019 13:58

addaleax approved these changes Jan 28, 2019

View reviewed changes

addaleax added the python PRs and issues that require attention from people who are familiar with Python. label Jan 28, 2019

cclauss mentioned this pull request Jan 28, 2019

build: update prerequisites on progress towards Python 3 #25766

Closed

4 tasks

cclauss force-pushed the patch-1 branch from 243eff0 to 24e260f Compare January 28, 2019 15:10

cclauss changed the title ~~test: makefile: PYTHON ?= python3~~ build: PYTHON ?= python3 Jan 28, 2019

This was referenced Jan 29, 2019

build: ongoing list of actions for Python 3 compatibility #25789

Closed

Add Python 3 to more build machines nodejs/build#1674

Closed

build: change PYTHON ?= python ---> PYTHON ?= python3

df16943

cclauss force-pushed the patch-1 branch from 2a5f697 to df16943 Compare February 1, 2019 17:17

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 9, 2019

thefourtheye approved these changes Feb 11, 2019

View reviewed changes

addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2019

richardlau added the blocked PRs that are blocked by other issues or PRs. label Feb 17, 2019

cclauss closed this Jul 5, 2019

cclauss deleted the patch-1 branch July 5, 2019 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: PYTHON ?= python3 #25759

build: PYTHON ?= python3 #25759

cclauss commented Jan 28, 2019 •

edited

gengjiawen commented Jan 28, 2019

thefourtheye commented Jan 28, 2019

cclauss commented Jan 28, 2019 •

edited

addaleax left a comment

thefourtheye commented Jan 28, 2019

thefourtheye commented Jan 28, 2019

gengjiawen commented Jan 28, 2019

thefourtheye commented Jan 28, 2019

addaleax commented Jan 28, 2019

refack commented Jan 28, 2019

cclauss commented Jan 28, 2019 •

edited

refack commented Jan 28, 2019

cclauss commented Jan 28, 2019 •

edited

refack commented Jan 29, 2019

gengjiawen commented Jan 29, 2019

refack commented Feb 1, 2019

refack commented Feb 1, 2019

addaleax commented Feb 9, 2019

addaleax commented Feb 17, 2019

addaleax commented Feb 17, 2019

cclauss commented Feb 17, 2019

cclauss commented Jul 5, 2019

build: PYTHON ?= python3 #25759

build: PYTHON ?= python3 #25759

Conversation

cclauss commented Jan 28, 2019 • edited

Checklist

gengjiawen commented Jan 28, 2019

thefourtheye commented Jan 28, 2019

cclauss commented Jan 28, 2019 • edited

addaleax left a comment

Choose a reason for hiding this comment

thefourtheye commented Jan 28, 2019

thefourtheye commented Jan 28, 2019

gengjiawen commented Jan 28, 2019

thefourtheye commented Jan 28, 2019

addaleax commented Jan 28, 2019

refack commented Jan 28, 2019

cclauss commented Jan 28, 2019 • edited

refack commented Jan 28, 2019

cclauss commented Jan 28, 2019 • edited

refack commented Jan 29, 2019

gengjiawen commented Jan 29, 2019

refack commented Feb 1, 2019

refack commented Feb 1, 2019

addaleax commented Feb 9, 2019

addaleax commented Feb 17, 2019

addaleax commented Feb 17, 2019

cclauss commented Feb 17, 2019

cclauss commented Jul 5, 2019

cclauss commented Jan 28, 2019 •

edited

cclauss commented Jan 28, 2019 •

edited

cclauss commented Jan 28, 2019 •

edited

cclauss commented Jan 28, 2019 •

edited