Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark/test-benchmark-streams failed #34409

Closed
richardlau opened this issue Jul 17, 2020 · 1 comment
Closed

benchmark/test-benchmark-streams failed #34409

richardlau opened this issue Jul 17, 2020 · 1 comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@richardlau
Copy link
Member

  • Test: benchmark/test-benchmark-streams
  • Platform: Ubuntu1604, IBM i
  • Console Output:
08:16:54 not ok 2783 benchmark/test-benchmark-streams
08:16:54   ---
08:16:54   duration_ms: 2.518
08:16:54   severity: fail
08:16:54   exitcode: 1
08:16:54   stack: |-
08:16:54     assert.js:385
08:16:54         throw err;
08:16:54         ^
08:16:54     
08:16:54     AssertionError [ERR_ASSERTION]: benchmark file not running exactly one configuration in test: 
08:16:54     streams/creation.js
08:16:54     streams/creation.js kind="duplex" n=1: 6,840.272790078869
08:16:54     
08:16:54     streams/pipe-object-mode.js
08:16:54     streams/pipe-object-mode.js n=1: 134.18694119525676
08:16:54     
08:16:54     streams/pipe.js
08:16:54     streams/pipe.js n=1: 127.79219557726546
08:16:54     
08:16:54     streams/readable-async-iterator.js
08:16:54     2
08:16:54     streams/readable-async-iterator.js sync="yes" n=1: 120.35939314793974
08:16:54     
08:16:54     streams/readable-bigread.js
08:16:54     streams/readable-bigread.js n=1: 29.298658098020184
08:16:54     
08:16:54     streams/readable-bigunevenread.js
08:16:54     streams/readable-bigunevenread.js n=1: 22.972824549899766
08:16:54     
08:16:54     streams/readable-boundaryread.js
08:16:54     streams/readable-boundaryread.js type="string" n=1: 17.122757569423193
08:16:54     
08:16:54     streams/readable-readall.js
08:16:54     streams/readable-readall.js n=1: 53.44909695078247
08:16:54     
08:16:54     streams/readable-unevenread.js
08:16:54     streams/readable-unevenread.js n=1: 15.20828514524817
08:16:54     
08:16:54     streams/writable-manywrites.js
08:16:54     streams/writable-manywrites.js len=1 callback="yes" writev="yes" sync="yes" n=1: 1,075.9039475991742
08:16:54     
08:16:54         at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1604-64/test/common/benchmark.js:38:12)
08:16:54         at ChildProcess.emit (events.js:314:20)
08:16:54         at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12) {
08:16:54       generatedMessage: false,
08:16:54       code: 'ERR_ASSERTION',
08:16:54       actual: false,
08:16:54       expected: true,
08:16:54       operator: '=='
08:16:54     }
08:16:54   ...

The benchmark tests have only recently been (re-?)enabled in #34288 cc @Trott.

  • Build Links:
@richardlau richardlau added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jul 17, 2020
@Trott
Copy link
Member

Trott commented Jul 17, 2020

PR to fix: #34411

@Trott Trott closed this as completed in d10c59f Jul 17, 2020
cjihrig pushed a commit that referenced this issue Jul 23, 2020
Extra output makes test-benchmark-streams fail. Change console.log() to
console.assert().

Fixes: #34409

PR-URL: #34411
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants