Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating Xu Meng as as Node.js collaborator #36569

Closed
mhdawson opened this issue Dec 18, 2020 · 10 comments
Closed

Nominating Xu Meng as as Node.js collaborator #36569

mhdawson opened this issue Dec 18, 2020 · 10 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@mhdawson
Copy link
Member

I would like to nominate @dmabupt as a collaborator on the Node.js project. He's being working hard on IBM i support for Node.js and being a collaborator would let him more easily do CI runs and help get things landed.

Commits in nodejs/node: https://github.com/nodejs/node/commits?author=dmabupt
Pull requests and issues in nodejs/node: https://github.com/nodejs/node/issues?q=author:dmabupt
Comments on pull requests and issues in nodejs/node: https://github.com/nodejs/node/issues?q=commenter:dmabupt
Reviews on pull requests in nodejs/node: https://github.com/nodejs/node/pulls?q=reviewed-by:dmabupt
Pull requests and issues opened throughout the Node.js organization: https://github.com/search?q=author:dmabupt+org:nodejs
Comments on pull requests and issues throughout the Node.js organization: https://github.com/search?q=commenter:dmabupt+org:nodejs

@PoojaDurgad PoojaDurgad added the meta Issues and PRs related to the general management of the project. label Dec 21, 2020
@mhdawson
Copy link
Member Author

mhdawson commented Jan 6, 2021

As per the governance for collaborator nominations this is now approved.

@dmabupt can you confirm that you accept?

@mhdawson mhdawson added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Jan 6, 2021
@mhdawson
Copy link
Member Author

mhdawson commented Jan 6, 2021

@gireeshpunathil since I think you have better timezone overlap with @dmabupt I'm wondering if you might be able to do the onboarding?

@gireeshpunathil
Copy link
Member

sure, I can do.

@mhdawson
Copy link
Member Author

mhdawson commented Jan 6, 2021

@gireeshpunathil thanks! Once @dmabupt confirms that he accepts I'll leave it up to you to schedule the onboarding.

@richardlau
Copy link
Member

@gireeshpunathil Specifically for @dmabupt 's onboarding it would be worth pointing out the CI job https://ci.nodejs.org/job/node-test-commit-ibmi/ which isn't currently run with the regular CI for pull requests (our IBM CI hosts are unfortunately too slow to do that for every PR) but is run daily and can be manually run via Jenkins if needed.

@gireeshpunathil
Copy link
Member

sure, thanks for the info, will take care of that.
(btw, @dmabupt is yet to confirm their acceptance)

@mhdawson mhdawson removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Jan 18, 2021
@dmabupt
Copy link
Contributor

dmabupt commented Jan 26, 2021

As per the governance for collaborator nominations this is now approved.

@dmabupt can you confirm that you accept?

Yes, I am pleased to accept that.
(Sorry for the late response. I was working on another project recently so I have not checked github notifications until today)

@mhdawson
Copy link
Member Author

@dmabupt great, I'll leave you and @gireeshpunathil to figure out a time to get together for the onboarding.

@gireeshpunathil
Copy link
Member

@dmabupt - thanks, I am off this week. I will connect with you early next week to agree on a date and time, to take it forward.

@gireeshpunathil
Copy link
Member

closed via #37377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants