Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add dmabupt to collaborators #37377

Closed
wants to merge 1 commit into from
Closed

doc: add dmabupt to collaborators #37377

wants to merge 1 commit into from

Conversation

dmabupt
Copy link
Contributor

@dmabupt dmabupt commented Feb 15, 2021

Fixes: #36569

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 15, 2021
@dmabupt
Copy link
Contributor Author

dmabupt commented Feb 15, 2021 •
edited

Please 👍 for fast-tracking

@gireeshpunathil gireeshpunathil added notable-change PRs with changes that should be highlighted in changelogs. meta Issues and PRs related to the general management of the project. labels Feb 15, 2021
@gireeshpunathil
Copy link
Member

pls note that this is earmarked for landing by @dmabupt per process. we were supposed to land it today itself as part of the onboarding, but it became late for them while we waited for approvals to come in. so leave it open for Xu Meng, for landing it tomorrow.

@dmabupt
Copy link
Contributor Author

dmabupt commented Feb 15, 2021

landed in 841c3e1

@dmabupt dmabupt closed this Feb 15, 2021
@gireeshpunathil
Copy link
Member

@dmabupt - I don't think it has landed - as I cannot see the commit in master. let us look at it tomorrow, if it is not fixed by then.

@Trott
Copy link
Member

Trott commented Feb 15, 2021

Definitely not landed. Re-opening.

@Trott Trott reopened this Feb 15, 2021
@Trott
Copy link
Member

Trott commented Feb 15, 2021

landed in 841c3e1

This was pushed to the master branch on @dmabupt's fork, but not here.

@dmabupt
Copy link
Contributor Author

dmabupt commented Feb 15, 2021 •
edited

landed in 841c3e1

This was pushed to the master branch on @dmabupt's fork, but not here.

Ah.. Yes, I set the wrong upstream url to fix an error --

$ git push upstream master
fatal: remote error: 
  You can't push to git://github.com/nodejs/node.git
  Use https://github.com/nodejs/node.git
$ git remote rm upstream
$ git remote add upstream git@github.com:dmabupt/node.git  <-- wrong url!
$ git push upstream master

It should be git@github.com:nodejs/node.git

dmabupt added a commit that referenced this pull request Feb 15, 2021
@dmabupt
doc: add dmabupt to collaborators
eec20ed 
PR-URL: #37377
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
@dmabupt
Copy link
Contributor Author

dmabupt commented Feb 15, 2021

landed in eec20ed

@dmabupt dmabupt closed this Feb 16, 2021
@gireeshpunathil gireeshpunathil mentioned this pull request Feb 16, 2021
Closed
@dmabupt dmabupt deleted the onboardme branch February 16, 2021 02:03
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@dmabupt @danielleadams
doc: add dmabupt to collaborators
d808db2 
PR-URL: #37377
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
danielleadams added a commit that referenced this pull request Feb 16, 2021
@danielleadams
2021-02-16, Version 15.9.0 (Current)
5133659 
Notable Changes:

* crypto:
  * add keyObject.export() 'jwk' format option (Filip Skokan) #37081
* deps:
  * upgrade to libuv 1.41.0 (Colin Ihrig) #37360
* doc:
  * add dmabupt to collaborators (Xu Meng) #37377
  * refactor fs docs structure (James M Snell) #37170
* fs:
  * add fsPromises.watch() (James M Snell) #37179
  * use a default callback for fs.close() (James M Snell) #37174
  * add AbortSignal support to watch (Benjamin Gruenbaum) #37190
* perf_hooks:
  * introduce createHistogram (James M Snell) #37155
* stream:
  * improve Readable.from error handling (Benjamin Gruenbaum) #37158
* timers:
  * introduce setInterval async iterator (linkgoron) #37153
* tls:
  * add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
This was referenced Feb 16, 2021
Closed
Merged
danielleadams added a commit that referenced this pull request Feb 17, 2021
@danielleadams
2021-02-17, Version 15.9.0 (Current)
889ffde 
Notable Changes:

* crypto:
  * add keyObject.export() 'jwk' format option (Filip Skokan) #37081
* deps:
  * upgrade to libuv 1.41.0 (Colin Ihrig) #37360
* doc:
  * add dmabupt to collaborators (Xu Meng) #37377
  * refactor fs docs structure (James M Snell) #37170
* fs:
  * add fsPromises.watch() (James M Snell) #37179
  * use a default callback for fs.close() (James M Snell) #37174
  * add AbortSignal support to watch (Benjamin Gruenbaum) #37190
* perf_hooks:
  * introduce createHistogram (James M Snell) #37155
* stream:
  * improve Readable.from error handling (Benjamin Gruenbaum) #37158
* timers:
  * introduce setInterval async iterator (linkgoron) #37153
* tls:
  * add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
danielleadams added a commit that referenced this pull request Feb 17, 2021
@danielleadams
2021-02-17, Version 15.9.0 (Current)
b471267 
Notable Changes:

* crypto:
  * add keyObject.export() jwk format option (Filip Skokan) #37081
* deps:
  * upgrade to libuv 1.41.0 (Colin Ihrig) #37360
* doc:
  * add dmabupt to collaborators (Xu Meng) #37377
  * refactor fs docs structure (James M Snell) #37170
* fs:
  * add fsPromises.watch() (James M Snell) #37179
  * use a default callback for fs.close() (James M Snell) #37174
  * add AbortSignal support to watch (Benjamin Gruenbaum) #37190
* perf_hooks:
  * introduce createHistogram (James M Snell) #37155
* stream:
  * improve Readable.from error handling (Benjamin Gruenbaum) #37158
* timers:
  * introduce setInterval async iterator (linkgoron) #37153
* tls:
  * add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
danielleadams added a commit that referenced this pull request Feb 17, 2021
@danielleadams
2021-02-17, Version 15.9.0 (Current)
877f66e 
PR-URL: #37406

Notable Changes:

* crypto:
  * add keyObject.export() jwk format option (Filip Skokan) #37081
* deps:
  * upgrade to libuv 1.41.0 (Colin Ihrig) #37360
* doc:
  * add dmabupt to collaborators (Xu Meng) #37377
  * refactor fs docs structure (James M Snell) #37170
* fs:
  * add fsPromises.watch() (James M Snell) #37179
  * use a default callback for fs.close() (James M Snell) #37174
  * add AbortSignal support to watch (Benjamin Gruenbaum) #37190
* perf_hooks:
  * introduce createHistogram (James M Snell) #37155
* stream:
  * improve Readable.from error handling (Benjamin Gruenbaum) #37158
* timers:
  * introduce setInterval async iterator (linkgoron) #37153
* tls:
  * add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
danielleadams added a commit that referenced this pull request Feb 18, 2021
@danielleadams
2021-02-17, Version 15.9.0 (Current)
3bf50a7 
PR-URL: #37406

Notable Changes:

* crypto:
  * add keyObject.export() jwk format option (Filip Skokan) #37081
* deps:
  * upgrade to libuv 1.41.0 (Colin Ihrig) #37360
* doc:
  * add dmabupt to collaborators (Xu Meng) #37377
  * refactor fs docs structure (James M Snell) #37170
* fs:
  * add fsPromises.watch() (James M Snell) #37179
  * use a default callback for fs.close() (James M Snell) #37174
  * add AbortSignal support to watch (Benjamin Gruenbaum) #37190
* perf_hooks:
  * introduce createHistogram (James M Snell) #37155
* stream:
  * improve Readable.from error handling (Benjamin Gruenbaum) #37158
* timers:
  * introduce setInterval async iterator (linkgoron) #37153
* tls:
  * add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
gimyhendrix7
gimyhendrix7 reviewed Mar 3, 2021
View reviewed changes
Copy link

@gimyhendrix7 gimyhendrix7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#20494

targos pushed a commit that referenced this pull request May 1, 2021
@dmabupt @targos
doc: add dmabupt to collaborators
07130c0 
PR-URL: #37377
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gimyhendrix7 gimyhendrix7 gimyhendrix7 left review comments

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nominating Xu Meng as as Node.js collaborator
7 participants
@dmabupt @gireeshpunathil @Trott @jasnell @richardlau @gimyhendrix7 @nodejs-github-bot