Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toWeb/fromWeb incorrectly listed as being added in 16.11 #40818

Closed
jasnell opened this issue Nov 15, 2021 · 1 comment
Closed

toWeb/fromWeb incorrectly listed as being added in 16.11 #40818

jasnell opened this issue Nov 15, 2021 · 1 comment
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.

Comments

@jasnell
Copy link
Member

jasnell commented Nov 15, 2021

Version

16.11

Platform

All

Subsystem

streams

What steps will reproduce the bug?

The documentation is incorrectly listing Node.js 16.11 as when the toWeb/fromWeb functions were added. Those are currently only in 17.x

https://nodejs.org/dist/latest-v17.x/docs/api/stream.html#streamreadablefromwebreadablestream-options

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

No response

Additional information

No response
lpinca added a commit to lpinca/node that referenced this issue Nov 15, 2021
@lpinca
Revert "doc: fix typo in stream docs"
e9eee81 
This reverts commit 1db2ffd.

Fixes: nodejs#40818
@lpinca lpinca mentioned this issue Nov 15, 2021
Closed
lpinca added a commit to lpinca/node that referenced this issue Nov 15, 2021
@lpinca
doc: fix added: info for Readable.fromWeb()
5ec14a9 
`stream.Readable.fromWeb()` was added to Node.js v17.0.0 via a99c230.

Refs: nodejs#40818
@lpinca lpinca mentioned this issue Nov 15, 2021
Closed
@Mesteery Mesteery added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Nov 15, 2021
lpinca added a commit that referenced this issue Nov 18, 2021
@lpinca
doc: fix added: info for Readable.fromWeb()
aa394ab 
`stream.Readable.fromWeb()` was added to Node.js v17.0.0 via a99c230.

PR-URL: #40820
Refs: #40818
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this issue Nov 21, 2021
@lpinca @targos
doc: fix added: info for Readable.fromWeb()
fe2cd09 
`stream.Readable.fromWeb()` was added to Node.js v17.0.0 via a99c230.

PR-URL: #40820
Refs: #40818
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs pushed a commit that referenced this issue Nov 24, 2021
@lpinca @BethGriggs
Revert "doc: fix typo in stream docs"
836fc27 
This reverts commit 1db2ffd.

Fixes: #40818

PR-URL: #40819
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@richardlau
Copy link
Member

This was fixed in #40820 and #40819.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasnell @richardlau @Mesteery