@nodejs/http

This is technically doable, but it will involve a PR in llhttp (the current Node.js HTTP parser) first and then it will be automatically supported by Node.
@evert Woud like to send a PR to llhttp to implement this?

cc @jasnell (http QUERY is your spec right?)

Yes! Interested in doing this. Will give this a shot

llhttp supports QUERY with nodejs/llhttp#265, so when released it will be possible to implement this on node

Cool, thanks for doing that!

When this PR #51719 is merged should be possible to support it

Hey folks, Im not seeing QUERY support in Node post #51719 landing

Should this have gone out in 21.7.2? based on https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V21.md#21.7.2

Guessing that it might need additional work in node? Expected support because http.METHODS lists QUERY currently

I'm using this as a test and tracking adding support in express in expressjs/express#5615:

// filename: http.js
const http = require('http');

// Do we know about query?
console.log(http.METHODS.includes('QUERY')) // true

// Create an HTTP server
const server = http.createServer((req, res) => {
  // Log the method to the console for verification
  console.log('Received method:', req.method);

  // Check if the method is QUERY
  if (req.method === 'QUERY') {
    res.writeHead(200, { 'Content-Type': 'text/plain' });
    res.end('Received a QUERY method request');
  } else {
    // Respond with Method Not Allowed if the method is not QUERY
    res.writeHead(405, { 'Content-Type': 'text/plain' });
    res.end('Method Not Allowed');
  }
});

// Listen on port 3000
server.listen(3000, () => {
  console.log('Server listening on port 3000');
});

node -v
# v21.7.3
node http.js
curl -i -X QUERY -H "Content-Type: application/json" -d '{"foo": "bar"}' http://localhost:3000

I see req.method as undefined, so fallthrough to my 405 here.

for completeness:

curl --version

curl 8.4.0 (x86_64-apple-darwin23.0) libcurl/8.4.0 (SecureTransport) LibreSSL/3.3.6 zlib/1.2.12 nghttp2/1.58.0
Release-Date: 2023-10-11
Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS GSS-API HSTS HTTP2 HTTPS-proxy IPv6 Kerberos Largefile libz MultiSSL NTLM NTLM_WB SPNEGO SSL threadsafe UnixSockets

And I am reproing locally on mac os, but also in GHA ubuntu-latest aka ubuntu-22.04

@ShogunPanda triaged the issue, and if Im not mistaken its a trivial bug on Node side

Does anyone know where we should look in code to add a path to support the QUERY method?

Does anyone know where we should look in code to add a path to support the QUERY method?

It should he already supported, there is just a little bug so its not listen in METHODS

Seems like I found the location, it's missing from HTTP_KNOWN_METHODS(V) 🕵️

I'm just not sure if it's the only place where we should be looking for, or is it?

@ShogunPanda may know more about it

Yes, I just submitted #52701. To address this.