doc: fix and modernize code examples in domain.md #11110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
evanlucas
reviewed
Feb 1, 2017
doc/api/domain.md
Outdated
| reqd.add(req); | ||
| reqd.add(res); | ||
| reqd.on('error', (er) => { | ||
| console.error('Error', er, req.url); | ||
| console.error(`Error ${er} ${req.url}`); |
There was a problem hiding this comment.
Won't this change remove the stack trace?
There was a problem hiding this comment.
Oh. Yes. Sorry.
I shall revert these ones. It seems something like Error ${util.format(err)} will be much worse.
There was a problem hiding this comment.
@evanlucas Reverted.
Fixed basing on the previous example.
4 tasks
|
cc @nodejs/documentation |
|
@evanlucas Could we proceed? |
evanlucas
approved these changes
Feb 9, 2017
jasnell
approved these changes
Feb 9, 2017
|
@evanlucas @jasnell Could this be landed? |
|
Yep LGTM. Can you land or would you like me to? Thanks! |
|
@evanlucas Sorry, I can't) I am not a collaborator) |
|
Landed in 5a42cd1. Thanks! |
evanlucas
pushed a commit
that referenced
this pull request
Feb 14, 2017
* var -> const * string concatenation -> template strings PR-URL: #11110 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 16, 2017
* var -> const * string concatenation -> template strings PR-URL: nodejs#11110 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 22, 2017
* var -> const * string concatenation -> template strings PR-URL: #11110 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
* var -> const * string concatenation -> template strings PR-URL: #11110 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
* var -> const * string concatenation -> template strings PR-URL: #11110 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* var -> const * string concatenation -> template strings PR-URL: #11110 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* var -> const * string concatenation -> template strings PR-URL: #11110 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, domain
FWIW, until the sealing of the
domain's vague fate.