Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make the rest of tests path-independent #12972

Closed
wants to merge 1 commit into from
Closed

test: make the rest of tests path-independent #12972

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented May 11, 2017 •
edited

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Permit spaces in paths to a Node.js executable and test scripts.

Fixes: #12773

@vsemozhetbyt vsemozhetbyt added the test Issues and PRs related to the tests. label May 11, 2017
@vsemozhetbyt
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/8014/

@vsemozhetbyt vsemozhetbyt mentioned this pull request May 11, 2017
Closed
Trott
Trott approved these changes May 11, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott
Copy link
Member

Trott commented May 11, 2017

@nodejs/testing

This is specifically about permitting spaces in the path, right? Might be good to make that explicit in the PR description and commit message.

@vsemozhetbyt
test: make the rest of tests path-independent
5e73b3e 
Permit spaces in paths to a Node.js executable and test scripts.

Fixes: #12773
@vsemozhetbyt
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/8022/

@vsemozhetbyt
Copy link
Contributor Author

Landed in 945f208

@vsemozhetbyt vsemozhetbyt deleted the test-node-path-independent branch May 14, 2017 13:07
vsemozhetbyt added a commit that referenced this pull request May 14, 2017
@vsemozhetbyt
test: make the rest of tests path-independent
945f208 
Permit spaces in paths to a Node.js executable and test scripts.

PR-URL: #12972
Fixes: #12773
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
@vsemozhetbyt
test: make the rest of tests path-independent
ecc7cbe 
Permit spaces in paths to a Node.js executable and test scripts.

PR-URL: nodejs#12972
Fixes: nodejs#12773
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorins
Copy link
Member

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace the backport request label with do-not-land if it shouldn't land

@vsemozhetbyt vsemozhetbyt mentioned this pull request Jun 22, 2017
Closed
3 tasks
@vsemozhetbyt
Copy link
Contributor Author

@MylesBorins Done: #13880

MylesBorins pushed a commit that referenced this pull request Jul 10, 2017
@vsemozhetbyt @MylesBorins
test: make the rest of tests path-independent
43fcb8f 
Permit spaces in paths to a Node.js executable and test scripts.

PR-URL: #12972
Fixes: #12773
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@vsemozhetbyt @MylesBorins
test: make the rest of tests path-independent
7419338 
Permit spaces in paths to a Node.js executable and test scripts.

PR-URL: #12972
Fixes: #12773
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vsemozhetbyt @Trott @MylesBorins @cjihrig