Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: remove compiler warning #13014

Closed
wants to merge 1 commit into from
Closed

n-api: remove compiler warning #13014

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

TryCatch without an Isolate* argument is deprecated, so add one.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

n-api

@addaleax
n-api: remove compiler warning
848586b 
`TryCatch` without an `Isolate*` argument is deprecated, so add one.
@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels May 13, 2017
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels May 13, 2017
@gibfahn
Copy link
Member

gibfahn commented May 13, 2017

Warning does indeed disappear.

[5/9] CXX obj/src/node.node_api.o
../../src/node_api.cc:2784:22: warning: 'TryCatch' is deprecated [-Wdeprecated-declarations]
        v8::TryCatch try_catch;
                     ^
../../deps/v8/include/v8.h:7886:40: note: 'TryCatch' has been explicitly marked deprecated here
  V8_DEPRECATED("Use isolate version", TryCatch());
                                       ^

@mscdex
Copy link
Contributor

mscdex commented May 13, 2017

Unrelated question: should all n-api PRs be tagged with 'dont-land-on-v{4,6,7}.x'?

@addaleax
Copy link
Member Author

@mscdex For now, yes… I guess we want to wait some time before backporting to v7.x and eventually v6.x

mhdawson
mhdawson approved these changes May 15, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/8097/

@mhdawson
Copy link
Member

CI good, landing.

@mhdawson
Copy link
Member

Landed as 0083011

@mhdawson mhdawson closed this May 16, 2017
mhdawson pushed a commit that referenced this pull request May 16, 2017
@addaleax @mhdawson
n-api: remove compiler warning
0083011 
`TryCatch` without an `Isolate*` argument is deprecated, so add one.

PR-URL: #13014
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
@addaleax
n-api: remove compiler warning
b9fa3fe 
`TryCatch` without an `Isolate*` argument is deprecated, so add one.

PR-URL: nodejs#13014
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@addaleax
n-api: remove compiler warning
d572c9c 
`TryCatch` without an `Isolate*` argument is deprecated, so add one.

PR-URL: nodejs#13014
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@addaleax @MylesBorins
n-api: remove compiler warning
8d3162d 
`TryCatch` without an `Isolate*` argument is deprecated, so add one.

Backport-PR-URL: #19447
PR-URL: #13014
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

@jasongin jasongin jasongin approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@addaleax @gibfahn @mscdex @mhdawson @TimothyGu @cjihrig @jasongin @nodejs-github-bot