test: Improve N-API test coverage #13044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add coverage for napi_get_prototype - add coverage for napi_strict_equals
nodejs-github-bot
added
node-api
jasongin
reviewed
May 16, 2017
| assert.strictEqual(test_general.testStrictEquals(val1, val2), false); | ||
| assert.ok(test_general.testStrictEquals(val2, val3)); | ||
|
|
||
| // test napi_strict_equals |
jasongin
approved these changes
May 16, 2017
Sounds good to me. I've certainly noticed how the build time is slowed by so many small test modules. It could be possible to put groups of tests in separate files in the same module, though that would require refactoring the init methods somewhat. |
cjihrig
approved these changes
May 16, 2017
|
Landed as 0dd8b9a |
mhdawson
added a commit
that referenced
this pull request
May 17, 2017
- add coverage for napi_get_prototype - add coverage for napi_strict_equals PR-URL: #13044 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
- add coverage for napi_get_prototype - add coverage for napi_strict_equals PR-URL: nodejs#13044 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
- add coverage for napi_get_prototype - add coverage for napi_strict_equals PR-URL: nodejs#13044 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue to chip away at missing coverage in my spare time.
Instead of creating addons for each of these I combined
them into test_general as they did not seem naturally
group with other functions. I was thinking that we
want less rather than more test addons, as each one adds to
the overall build time. If there is general agreement
with that I might move some of the other existing tests
into test_general in cases were there is only 1 or 2
functions being tested in the existing grouping.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, n-api