test: Make N-API weak-ref GC tests asynchronous #13121

jasongin · 2017-05-19T19:47:49Z

One of the N-API weak-reference test cases already had to be made asynchronous to handle different behavior in a newer V8 version. (0a734fe) When porting N-API to Node-ChakraCore, we found more of the test cases needed similar treatment. (nodejs/node-chakracore#246) So to make thes tests more robust (and avoid having differences in the test code for Node-ChakraCore), I am refactoring the tests in this file to insert a setImmedate() callback before every call to gc() and assertions about the effects of the GC.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test

jasongin · 2017-05-19T19:48:18Z

@targos @mhdawson Please review.

mhdawson · 2017-05-19T21:11:41Z

test/addons-napi/test_reference/test.js

-  value = null;
-  global.gc(); // Value should NOT be GC'd because there is a strong ref
-  assert.strictEqual(test_reference.finalizeCount, 0);
+  'External value without a finalizer',


Would it be better to make it an array of objects instead of doing the string check for the title ?
ex
{ title: 'External value without a finalizer', steps: [() => {...}, () => {...}, etc ]}

That would work too, but would be more complicated to do the nested iteration recursively. I didn't see a need to over-design this just for these few tests. I can do it if you want. :)

I was thinking it would actually be easier/less code, but if you don't think that's the case I don't want to hold up getting this landed. I may take a look/PR later on when I have time if what I was thinking can simply, if not then I'll leave it be.

- Make GC tests (arraybuffer, buffer) async, to account for different GC behavior with different versions of V8 and ChakraCore, similar to nodejs/node#13121 - In test/index.js, use the --napi-modules and --expose-gc command-line flags automatically

- Make GC tests (arraybuffer, buffer, external) async, to account for different GC behavior with different versions of V8 and ChakraCore, similar to nodejs/node#13121 - In test/index.js, use the --napi-modules and --expose-gc command-line flags automatically

- Make GC tests (arraybuffer, buffer, external) async, to account for different GC behavior with different versions of V8 and ChakraCore, similar to nodejs/node#13121 - In test/index.js, use the --napi-modules and --expose-gc command-line flags automatically. - Add missing entry for object tests in index.js. - Remove check for writable attribute on accessor property descriptors; it should not be there according to the JS spec. - Remove the explicit dependency on node-gyp in package.json. (NPM carries its own copy of node-gyp.)

cjihrig · 2017-05-22T14:21:08Z

test/addons-napi/test_reference/test.js

+      title = tests[i];
+      runTests(i + 1, title, tests);
+    } else {
+      try {


Couldn't you replace the try...catch, throw, and console.error() call with a call to assert.doesNotThrow()?

That could work, except assert.doesNotThrow() loses the stack trace of the original exception; it only displays the message. So I prefer not to use it except when checking for a very specific exceptional condition. In this case, the original exception stack trace is likely to point to a line number of another assertion in the file, so that's very helpful information.

- Make GC tests (arraybuffer, buffer, external) async, to account for different GC behavior with different versions of V8 and ChakraCore, similar to nodejs/node#13121 - In test/index.js, use the --napi-modules and --expose-gc command-line flags automatically. - Add missing entry for object tests in index.js. - Remove check for writable attribute on accessor property descriptors; it should not be there according to the JS spec. - Remove the explicit dependency on node-gyp in package.json. (NPM carries its own copy of node-gyp.)

- Make GC tests (arraybuffer, buffer, external) async, to account for different GC behavior with different versions of V8 and ChakraCore, similar to nodejs/node#13121 - In test/index.js, use the --napi-modules and --expose-gc command-line flags automatically. - Add missing entry for object tests in index.js. - Remove check for writable attribute on accessor property descriptors; it should not be there according to the JS spec. - Remove the explicit dependency on node-gyp in package.json. (NPM carries its own copy of node-gyp.) - Fix improper rethrow of an Error caught by reference that caused a double napi_ref delete, which failed in release builds of Node-ChakraCore.

jasongin · 2017-05-24T17:00:04Z

@cjihrig @mhdawson Do you think changes are needed or is this good?

jasongin · 2017-05-24T17:34:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/8285/

Review dismissed

mhdawson

LGTM

One of the N-API weak-reference test cases already had to be made asynchronous to handle different behavior in a newer V8 version: nodejs#12864 When porting N-API to Node-ChakraCore, we found more of the test cases needed similar treatment: nodejs/node-chakracore#246 So to make thes tests more robust (and avoid having differences in the test code for Node-ChakraCore), I am refactoring the tests in this file to insert a `setImmedate()` callback before every call to `gc()` and assertions about the effects of the GC. PR-URL: nodejs#13121 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasongin · 2017-05-30T19:59:31Z

Landed as bb91879

One of the N-API weak-reference test cases already had to be made asynchronous to handle different behavior in a newer V8 version: #12864 When porting N-API to Node-ChakraCore, we found more of the test cases needed similar treatment: nodejs/node-chakracore#246 So to make thes tests more robust (and avoid having differences in the test code for Node-ChakraCore), I am refactoring the tests in this file to insert a `setImmedate()` callback before every call to `gc()` and assertions about the effects of the GC. PR-URL: #13121 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Fixed by upstream PR nodejs/node#13121 Resolves nodejs#246

Fixed by upstream PR nodejs/node#13121 Resolves nodejs#246 PR-URL: nodejs#301 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>

One of the N-API weak-reference test cases already had to be made asynchronous to handle different behavior in a newer V8 version: nodejs#12864 When porting N-API to Node-ChakraCore, we found more of the test cases needed similar treatment: nodejs/node-chakracore#246 So to make thes tests more robust (and avoid having differences in the test code for Node-ChakraCore), I am refactoring the tests in this file to insert a `setImmedate()` callback before every call to `gc()` and assertions about the effects of the GC. PR-URL: nodejs#13121 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

One of the N-API weak-reference test cases already had to be made asynchronous to handle different behavior in a newer V8 version: #12864 When porting N-API to Node-ChakraCore, we found more of the test cases needed similar treatment: nodejs/node-chakracore#246 So to make thes tests more robust (and avoid having differences in the test code for Node-ChakraCore), I am refactoring the tests in this file to insert a `setImmedate()` callback before every call to `gc()` and assertions about the effects of the GC. Backport-PR-URL: #19447 PR-URL: #13121 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

- Make GC tests (arraybuffer, buffer, external) async, to account for different GC behavior with different versions of V8 and ChakraCore, similar to nodejs/node#13121 - In test/index.js, use the --napi-modules and --expose-gc command-line flags automatically. - Add missing entry for object tests in index.js. - Remove check for writable attribute on accessor property descriptors; it should not be there according to the JS spec. - Remove the explicit dependency on node-gyp in package.json. (NPM carries its own copy of node-gyp.) - Fix improper rethrow of an Error caught by reference that caused a double napi_ref delete, which failed in release builds of Node-ChakraCore.

nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels May 19, 2017

mhdawson reviewed May 19, 2017

View reviewed changes

digitalinfinity approved these changes May 20, 2017

View reviewed changes

jasongin mentioned this pull request May 20, 2017

Make tests work on all Node versions nodejs/node-addon-api#44

Merged

cjihrig previously requested changes May 22, 2017

View reviewed changes

addaleax added dont-land-on-v4.x labels May 23, 2017

mhdawson approved these changes May 24, 2017

View reviewed changes

digitalinfinity approved these changes May 30, 2017

View reviewed changes

jasongin force-pushed the reference_test_gc branch from 6334a1b to bb91879 Compare May 30, 2017 19:58

jasongin closed this May 30, 2017

jasongin merged commit bb91879 into nodejs:master May 30, 2017

jasongin deleted the reference_test_gc branch May 30, 2017 20:00

jasnell mentioned this pull request Jun 5, 2017

8.1.0 Proposal #13483

Closed

kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Jun 15, 2017

test: enable addons-napi/test_reference

9d981c7

Fixed by upstream PR nodejs/node#13121 Resolves nodejs#246

kfarnung mentioned this pull request Jun 15, 2017

test: enable addons-napi/test_reference nodejs/node-chakracore#301

Merged

2 tasks

targos mentioned this pull request Aug 29, 2017

test: fix tests after V8 6.0 GC changes TooTallNate/ref#85

Merged

MylesBorins mentioned this pull request Apr 16, 2018

v6.14.2 proposal #19996

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Make N-API weak-ref GC tests asynchronous #13121

test: Make N-API weak-ref GC tests asynchronous #13121

jasongin commented May 19, 2017

jasongin commented May 19, 2017

mhdawson May 19, 2017

jasongin May 19, 2017 •

edited

mhdawson May 24, 2017

cjihrig May 22, 2017

jasongin May 22, 2017 •

edited

jasongin commented May 24, 2017

jasongin commented May 24, 2017

mhdawson left a comment

jasongin commented May 30, 2017

test: Make N-API weak-ref GC tests asynchronous #13121

test: Make N-API weak-ref GC tests asynchronous #13121

Conversation

jasongin commented May 19, 2017

Checklist

Affected core subsystem(s)

jasongin commented May 19, 2017

mhdawson May 19, 2017

Choose a reason for hiding this comment

jasongin May 19, 2017 • edited

Choose a reason for hiding this comment

mhdawson May 24, 2017

Choose a reason for hiding this comment

cjihrig May 22, 2017

Choose a reason for hiding this comment

jasongin May 22, 2017 • edited

Choose a reason for hiding this comment

jasongin commented May 24, 2017

jasongin commented May 24, 2017

mhdawson left a comment

Choose a reason for hiding this comment

jasongin commented May 30, 2017

jasongin May 19, 2017 •

edited

jasongin May 22, 2017 •

edited