test: add coverage for napi_property_descriptor #13510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did not have test coverage for using a napi_value pointing to a string or symbol for the name when creating a property. Add that coverage.
nodejs-github-bot
added
node-api
|
Should we also have a test case that uses a symbol as a property name? |
|
@jasongin added commit to add test for creating property with a symbol. |
jasongin
approved these changes
Jun 8, 2017
|
Killed one part of one run on windows (after 4 hours) https://ci.nodejs.org/job/node-test-binary-windows/9109/RUN_SUBSET=0,VS_VERSION=vs2015,label=win2012r2/ |
|
I had accidentally kicked off 2 CI runs, the the link to the one posted in this PR passed, so issue is likely not related to PR. |
|
Failure looks infra related as it did not get to the point of running tests. |
|
Landed as 01f4d9a |
mhdawson
added a commit
that referenced
this pull request
Jun 9, 2017
We did not have test coverage for using a napi_value pointing to a string or symbol for the name when creating a property. Add that coverage. PR-URL: #13510 Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
addaleax
pushed a commit
that referenced
this pull request
Jun 10, 2017
We did not have test coverage for using a napi_value pointing to a string or symbol for the name when creating a property. Add that coverage. PR-URL: #13510 Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Merged
3 tasks
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
We did not have test coverage for using a napi_value pointing to a string or symbol for the name when creating a property. Add that coverage. PR-URL: nodejs#13510 Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not have test coverage for using a napi_value
pointing to a string or symbol for the name when
creating a property. Add that coverage.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, n-api