Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document napi_finalize() signature #14230

Merged
merged 1 commit into from Jul 31, 2017
Merged

doc: document napi_finalize() signature #14230

merged 1 commit into from Jul 31, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 14, 2017

Refs: #14138

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Jul 14, 2017
mhdawson
mhdawson approved these changes Jul 14, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 31, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9420/

@cjihrig
doc: document napi_finalize() signature
6968ead 
Refs: nodejs#14138
PR-URL: nodejs#14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@cjihrig cjihrig merged commit 6968ead into nodejs:master Jul 31, 2017
@cjihrig cjihrig deleted the finalize-docs branch July 31, 2017 15:27
addaleax pushed a commit that referenced this pull request Aug 1, 2017
@cjihrig @addaleax
doc: document napi_finalize() signature
fffd8f5 
Refs: #14138
PR-URL: #14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@addaleax addaleax mentioned this pull request Aug 2, 2017
Merged
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@cjihrig
doc: document napi_finalize() signature
fb41b01 
Refs: nodejs#14138
PR-URL: nodejs#14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@cjihrig @MylesBorins
doc: document napi_finalize() signature
831de61 
Refs: #14138
Backport-PR-URL: #19447
PR-URL: #14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@tniessen tniessen tniessen approved these changes

@mhdawson mhdawson mhdawson approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cjihrig @refack @jasnell @tniessen @mhdawson @gibfahn @MylesBorins @nodejs-github-bot