[v4.x] deps: revert/re-apply 09db540 from upstream v8

[abernix]

This PR aims to fix an improperly applied backport to the v8 deps on the v4.x series.

As discussed and discovered in #14228, the original intention of 3e8d7a7 was to apply v8/v8@e093a04 and v8/v8@09db540 but that backport commit failed to consider that the former commit (e093) was reverted in v8/v8@5f5a328. This led to inadvertent changes (which were never present on v8) to MarkCompactCollector::ClearWeakCollections being left in place on the Node.js 4.x series, in addition to the (incorrect) changes to the weakset and weakmap tests.

That MarkCompactCollector change is directly responsible for some errors, specifically noted in the stack traces of the post-mortems reported by myself and others in #14228 and meteor/meteor#8970 (comment).

Furthermore, while the correct fix to v8 was meant to apply the "Wipe deleted entries" logic to HashTable::Rehash it was also applied to CompilationCacheTable::Age as well. You'll note that an additional, seemingly arbitrary capacity variable needed to be declared in the backport which was not present in the original patch. Not too surprising as the patch applies cleanly to that class as well, albeit with a several thousand line patch offset. (This caught me off guard during debugging as well and it looks as if the v8 team was also bit by this temporarily in v8/v8@59c7657!)

In this process, I also took the liberty to backport the very relevant v8/v8@686558d which corrects the comment on the original commit.

It's my belief that this now matches up with the intended fix for #6180 and crbug.com/v8/4909 and also maintains relevant follow-ups, such as v8/v8@b93c80a6 and v8/v8@a76d133f.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

V8 Engine

This is my first v8 commit, so happy to adjust accordingly, but this is what I've found!

[addaleax]

@nodejs/v8 @MylesBorins

[bnoordhuis]

Thanks, LGTM.

CI: https://ci.nodejs.org/job/node-test-pull-request/9669/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/854/

[jasnell]

ping @nodejs/lts

[MylesBorins]

test of v4.8.4 for comparison

ci: https://ci.nodejs.org/job/node-test-commit/11812/
v8: https://ci.nodejs.org/job/node-test-commit-v8-linux/856/

[MylesBorins]

Failures in CI are unrelated
fc6d118...5d7f68a

[benjamn]

Meteor is considering shipping a version of Node 4.8.4 with this patch, just until 4.8.5 is out. Do you (@MylesBorins, @nodejs/lts, et al.) have any guidance about (1) whether that's a terrible idea, and (2) when 4.8.5 might be released?

[MylesBorins]

@benjamn floating the patch is not a terrible idea

next v4.x is likely in October, but perhaps we should ship it in september as the backlog is building

have an issue open about it nodejs/Release#241