Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js 8.6.0 Release Proposal #15509

Merged
merged 145 commits into from
Sep 26, 2017
Merged

Node.js 8.6.0 Release Proposal #15509

merged 145 commits into from
Sep 26, 2017

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 20, 2017 •
edited

Target Release Date: 2017-09-26

Notable Changes

  • crypto
    • Support for multiple ECDH curves. #15206
  • dgram
    • Added setMulticastInterface() API. #7855
  • n-api
    • The command-line flag is no longer required to use N-API. #14902
  • tls
    • Docs-only deprecation of parseCertString(). #14245
  • New Contributors

Commits

MylesBorins and others added 30 commits September 14, 2017 13:43
@MylesBorins
errors: backport ERR_INVALID_PROTOCOL to v8.x
da3265a 
This error code originally landed in a semver-major commit and is used
by the ESM implementation. This backport includes the error message
and the documentation for the error.

I did attempt to write a test for this, but it did not seem possible
to catch an exception during import, I was also unable to execute
`node --experimental-modules` properly inside of a child_process.

I'll dig more into getting a test together, but we should backport
this fix in the mean time.

Refs: #14423
Fixes: #15374

PR-URL: #15388
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
docs: update 8.5.0 changelog
a792ea7 
The original changelog included incorrect information regarding
the new perf_hooks api.

refs: #15308 (comment)

PR-URL: #15384
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gergelyke @jasnell
test: backward compatible api for tty
d82ae0c 
PR-URL: #15235
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@lpinca @jasnell
doc: add documentation for the 'timeout' event
7fa2bee 
Adds the `'timeout'` event to the `http.ClientRequest` documentation.

PR-URL: #15443
Fixes: #14856
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@apapirovski @jasnell
test: expand http2 frameError test case
389c8c3 
Expand maxSendHeaderBlockLength test to check what happens if
frameError listener isn't available.

PR-URL: #15298
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@mcollina @jasnell
http: revert #14024 writable is never set to false
771c2ac 
Setting writable = false in IncomingMessage.end made some errors
being swallowed in some very popular OSS libraries that we must
support. This commit add some of those use cases to the tests,
so we avoid further regressions.
We should reevaluate how to set writable = false in IncomingMessage
in a way that does not break the ecosystem.

See: #14024
Fixes: #15029
PR-URL: #15404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@apapirovski @jasnell
http2: expand list of known headers
b9a9290 
Add access-control-*, dnt, forwarded, trailer, tk,
upgrade-insecure-requests, warning, x-content-type-options and
x-frame-options to known list of headers for HTTP2. Expand tests
to account for these headers.

Fixes: #15337
Refs: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers
Refs: https://www.w3.org/TR/cors/#syntax
Refs: https://www.w3.org/2011/tracking-protection/drafts/tracking-dnt.html#dnt-header-field
Refs: https://tools.ietf.org/html/rfc7239#section-4
Refs: https://tools.ietf.org/html/rfc7230#section-4.4
Refs: https://www.w3.org/2011/tracking-protection/drafts/tracking-dnt.html#response-header-field
Refs: https://www.w3.org/TR/upgrade-insecure-requests/#preference
Refs: https://tools.ietf.org/html/rfc7234#section-5.5
Refs: https://fetch.spec.whatwg.org/#x-content-type-options-header
Refs: https://tools.ietf.org/html/rfc7034

PR-URL: #15434
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@rogaps @jasnell
crypto: support multiple ECDH curves and auto
bd07574 
Using SSL_CTX_set1_curves_list() (OpenSSL 1.0.2+), this allows to set
colon separated ECDH curve names in SecureContext's ecdhCurve option.
The option can also be set to "auto" to select the curve automatically
from list built in OpenSSL by enabling SSL_CTX_set_ecdh_auto()
(OpenSSL 1.0.2+).

PR-URL: #15206
Ref: #15054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danbev @jasnell
timers: clarify lib/timer.js comment
6a94c1a 
PR-URL: #11018
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Lance Ball <lball@redhat.com>
@BridgeAR @jasnell
lib: refactor console startup
8ce0e9a 
PR-URL: #15111
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Trott @jasnell
test: do not write fixture in test-require-symlink
f20fb4c 
test-require-symlink modifies the fixture directory by adding a symlink.
Copy the fixture to the test tmpdir instead of modifying the fixture
directory.

This also uses a more empirical test for checking for the ability to
make symlinks on Windows.

PR-URL: #15067
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@psmarshall @jasnell
benchmark: use smaller n value in some http tests
142d2ed 
PR-URL: #14002
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@barnski @jasnell
src: remove outdated todo from node_crypto.cc
8c480f9 
TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.

PR-URL: #15104
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@manidlou @jasnell
doc: fix entryTypes type and missing link
bdfed1a 
PR-URL: #15406
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@bzoz @jasnell
doc: make mkdtemp example work on Windows
acb0d01 
PR-URL: #15408
Fixes: #14960
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@bzoz @jasnell
build: add support for link-module to vcbuild
5d217ad 
Adds support for link-module option to vcbuild.bat.

PR-URL: #15410
Fixes: #15377
Reviewed-By: Refael Ackermann <refack@gmail.com>
@jasnell
doc: prevent displaying empty version picker
f0e411d 
PR-URL: #15420
Fixes: #15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@apapirovski @jasnell
http2: emit close event if request aborted
2ea2725 
Fix Http2ServerRequest and Http2ServerResponse to emit close event
if the request is aborted before response.end can be called.

Fixes: #15385
PR-URL: #15415
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@apapirovski @jasnell
test: fix flaky test-http2-session-timeout
1fbdf47 
Increase server timeout, reduce frequency of calls and
unbind timeout after runs are done in order to avoid
race conditions. Temporarily moved to sequential.

Fixes: #15326
PR-URL: #15338
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@antoine-amara @jasnell
doc: fix http.ClientRequest method descriptions
b5c1a82 
fix documentation for methods getHeader, setHeader and removeHeader
for http.ClientRequest class. The documentation said these functions
can be called but they're wasn't describe into the API description yet.

add parameters and general description for each methods.

PR-URL: #15163
Fixes: #15048
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott @jasnell
benchmark: provide default methods for assert
d30a583 
The benchmarks for `assert` all take a `method` configuration option,
but the allowable values are different across the files. For each
benchmark, provide an arbitrary default if `method` is set to an empty
string. This allows all the `assert` benchmarks to be run with a single
command but only on a single method. This is primarily useful for
testing that the assert benchmark files don't contain egregious errors.
(In other words, it's useful for testing.)

PR-URL: #15174
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott @jasnell
benchmark: enable assert benchmark with short len
3bf718c 
`deepequal-typedarrays.js` throws if `len` is set to 100 or less due to
a hardcoded index. Calculate the index based on `len` so benchmark can
be run with small `len` values if desired.

PR-URL: #15174
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bmeck @jasnell
module: coverity fixes for ESM C++
939c8ed 
PR-URL: #15275
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@guybedford @jasnell
module: check file url passed to top-level import
c005713 
Fixes: #15374
PR-URL: #15389
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Oblosys @jasnell
doc: fix emitKeypressEvents stream type
a53a0d8 
PR-URL: #15399
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
async_hooks,doc: some async_hooks improvements
81723a9 
Update docs and type checking for AsyncResource type

PR-URL: #15103
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@Trott @jasnell
test: move test-benchmark-buffer to sequential
4d26c68 
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS.
Move the test to `sequential` so it is not competing with other tests
for resources.

PR-URL: #15373
Fixes: #15372
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
n-api: napi_is_construct_call->napi_get_new_target
a2d340f 
Remove napi_is_construct_call and introduce napi_get_new_target.

PR-URL: #14698
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
@boingoing @jasnell
n-api: refactor napi_addon_register_func
8f12b9d 
As per discussion in abi-stable-node:
nodejs/abi-stable-node#256,
take a refactor to napi_addon_register_func such that
the result from the register function is assigned to
the module exports property. By making this change,
native module can be agnostic about which type of
module the environment supports.

PR-URL: #15088
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
@addaleax @jasnell
src: move DomainEnter,DomainExit to node.cc
6c520af 
PR-URL: #14697
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bengl @jasnell
doc: ctc -> tsc in onboarding extras
f6b4844 
PR-URL: #15621
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell jasnell force-pushed the v8.6.0-proposal branch 2 times, most recently from 48d7f58 to 1732dac Compare September 26, 2017 15:04
@jasnell
Copy link
Member Author

jasnell commented Sep 26, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10277/

@jasnell
Copy link
Member Author

jasnell commented Sep 26, 2017

@nodejs/collaborators @nodejs/tsc ... please take a final look. This will be going out today.

@Fishrock123
Copy link
Member

Fishrock123 commented Sep 26, 2017 •
edited

Were the N-API changes that were wanted to be made before it was unflagged ever done?

Certainly seems fine otherwise.
There isn't any mention of it, is this supposed to be LTS: Carbon?

@jasnell
Copy link
Member Author

jasnell commented Sep 26, 2017

There isn't any mention of it, is this supposed to be LTS: Carbon?

No. The LTS release will come later.

@jasnell
Copy link
Member Author

jasnell commented Sep 26, 2017

Were the N-API changes that were wanted to be made before it was unflagged ever done?

As far as I understand.

@lpinca
Copy link
Member

lpinca commented Sep 26, 2017

@jasnell it would be nice to land #15581 on master and add it to this release if it's not to late, otherwise no problem.

@rebornix @jasnell
doc: fix outdated code sample in n-api.md
0a050e9 
code samples of napi_create_object and napi_property_descriptor were
not updated to latest API.

PR-URL: #15581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Sep 26, 2017

@lpinca ... done

mcollina
mcollina approved these changes Sep 26, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos @jasnell
path: fix normalize paths ending with two dots
19d2d66 
Fixes: nodejs-private/security#147
PR-URL: nodejs-private/node-private#94
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Doug Wilson <doug@somethingdoug.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell
Copy link
Member Author

jasnell commented Sep 26, 2017

Release build started: https://ci-release.nodejs.org/job/iojs+release/2048/

@jasnell
Copy link
Member Author

jasnell commented Sep 26, 2017

Unable to proceed with the build due to an issue with the ci-release infrastructure. No response yet from @nodejs/build team members .

@jasnell
2017-09-26, Node.js Version 8.6.0 (Current)
b48ff2a 
* **crypto**
  * Support for multiple ECDH curves. [#15206](#15206)
* **dgram**
  * Added `setMulticastInterface()` API. [#7855](#7855)
  * Custom lookup functions are now supported. [#14560](#14560)
* **n-api**
  * The command-line flag is no longer required to use N-API. [#14902](#14902)
* **tls**
  * Docs-only deprecation of `parseCertString()`. [#14245](#14245)
* **New Contributors**
  * Welcome Sebastiaan Deckers (@sebdeckers) as a new Collaborator! [#15354](#15354)
@jasnell
Working on v8.6.1
69a2405 
PR-URL: #15509
@jasnell
Copy link
Member Author

jasnell commented Sep 26, 2017

New Release CI: https://ci-release.nodejs.org/job/iojs+release/2054/

@gibfahn
Copy link
Member

gibfahn commented Sep 26, 2017

No response yet from @nodejs/build team members .

Did you just ping on IRC? Didn't see anything in nodejs/build or nodejs/node.

@jasnell
Copy link
Member Author

jasnell commented Sep 26, 2017

It's up and going now. I pinged in the node-dev channel, pinged several individually via irc, pinged michael via hangouts and twitter dm... didn't want to spam the entire team tho :-)

@jasnell jasnell merged commit 69a2405 into v8.x Sep 26, 2017
@jasnell jasnell mentioned this pull request Sep 26, 2017
Merged
jasnell added a commit to nodejs/nodejs.org that referenced this pull request Sep 26, 2017
@jasnell
Blog: v8.6.0 release post
d8290e7 
Refs: nodejs/node#15509
jasnell added a commit to nodejs/nodejs.org that referenced this pull request Sep 26, 2017
@jasnell
Blog: v8.6.0 release post (#1378)
267cd83 
Refs: nodejs/node#15509
@jasnell jasnell deleted the v8.6.0-proposal branch September 26, 2017 22:09
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@jasnell @MylesBorins
Working on v8.6.1
150a1c4 
PR-URL: #15509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet