New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: make more symbols local #16234

Closed

gabrielschulhof wants to merge 1 commit into nodejs:master from gabrielschulhof:napi-extern-hidden

Commits on Oct 16, 2017

n-api: unexpose symbols and remove EXTERNAL_NAPI

* namespaced functions such as v8impl::JsHandleScopeFromV8HandleScope
  become part of Node's public symbols unless they are declared static.
* the class uvimpl::Work needs to be enclosed in an anonymous namespace
  else it, too becomes part of Node's public symbols.
* remove references to EXTERNAL_NAPI.

Gabriel Schulhof committed Oct 16, 2017