Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add description for inspector-only console methods. #17004

Closed
wants to merge 12 commits into from

Commits on Nov 19, 2017

  1. doc: add description for inspector-only console methods.

    Description inspired by dev tools reference and inspector err messages
    
    Added:
    * intro
    * console.debug()
    * console.dirxml()
    * console.markTimeline()
    * console.profile()
    * console.profileEnd()
    * console.table()
    * console.timeStamp()
    * console.timeline()
    * console.timelineEnd()
    
    Fixes: nodejs#16755
    Tiriel committed Nov 19, 2017
    Copy the full SHA
    bbf4ffa View commit details
    Browse the repository at this point in the history
  2. doc: add warning for inspector-only methods in console.md

    Following comments on original PR, added warning in each method's description
    
    Fixes: nodejs#16755
    Refs: nodejs#17004 (comment)
    Tiriel committed Nov 19, 2017
    Copy the full SHA
    eab906a View commit details
    Browse the repository at this point in the history
  3. doc: add missing references and correcting style

    Following review, changed one ref and added missing ones.
    Also corrected casing on non-primitive values.
    
    Fixes: nodejs#16755
    Tiriel committed Nov 19, 2017
    Copy the full SHA
    c95317d View commit details
    Browse the repository at this point in the history
  4. doc: add link to debugger.html in inspector methods intro

    Following review on PR
    
    Fixes: nodejs#16755
    Tiriel committed Nov 19, 2017
    Copy the full SHA
    757f182 View commit details
    Browse the repository at this point in the history
  5. doc: corrected nits to console.md

    Following review, removed tab references.
    
    Fixes: nodejs#16755
    Tiriel committed Nov 19, 2017
    Copy the full SHA
    1bef307 View commit details
    Browse the repository at this point in the history
  6. doc: removing description for console.debug

    As seen in PR nodejs#17033, console.debug() is being fully implemented.
    Removing its description from here to include it in the other PR
    
    Fixes: nodejs#16755
    Refs: nodejs#17033 (comment)
    Tiriel committed Nov 19, 2017
    Copy the full SHA
    d9ec8a3 View commit details
    Browse the repository at this point in the history
  7. doc: change implementation version number for console.debug

    Following comment in PR nodejs#17033, and since this block of doc was first written
    in this PR, changing the implementation version number for console.debug().
    Making it v9.2.x for now, waiting for next release.
    
    Fixes: nodejs#17033 (comment)
    Tiriel committed Nov 19, 2017
    Copy the full SHA
    fd88a45 View commit details
    Browse the repository at this point in the history
  8. doc: replace pseudo version number with constant

    Following review, replaced pseudo version number with REPLACEME
    
    Refs: nodejs#17004 (review)
    Fixes: nodejs#16755
    Tiriel committed Nov 19, 2017
    Copy the full SHA
    343a92d View commit details
    Browse the repository at this point in the history
  9. doc: add changes version number and missing arguments

    Following reviews
    Tiriel committed Nov 19, 2017
    Copy the full SHA
    0d06595 View commit details
    Browse the repository at this point in the history
  10. doc: fixed versionning block

    Following review
    Tiriel committed Nov 19, 2017
    Copy the full SHA
    9ffff7b View commit details
    Browse the repository at this point in the history
  11. doc: double quoting yaml value starting with backticks

    Make and make test return yaml linting errors on first parsing.
    Tiriel committed Nov 19, 2017
    Copy the full SHA
    38f49c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2017

  1. doc: fix console.table signature

    Replacing rest operator with <array>column parameter
    
    Ref: nodejs#17004 (review)
    Tiriel committed Nov 20, 2017
    Copy the full SHA
    1d9981f View commit details
    Browse the repository at this point in the history