v9.5.0 release proposal #18464
Merged
v9.5.0 release proposal #18464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the method is inherited from `Writable`, usage of the method does not change at all after its removal as an explicit method. Calling it out as notable might therefore be more confusing than helpful. PR-URL: #18083 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original commit message:
[parser] Add new FunctionNameInferrer state before parsing param
Create new state before parsing FormalParameter because we don't
want to use any of the parameters as an inferred function name.
Previously the stacktrace was:
test.js:3: Error: boom
throw new Error('boom');
^
Error: boom
at param (test.js:3:11)
at test.js:4:5
at test.js:6:3
The stacktrace with this patch:
test.js:3: Error: boom
throw new Error('boom');
^
Error: boom
at test.js:3:11
at test.js:4:5
at test.js:6:3
Bug: v8:6822, v8:6513
Change-Id: Ifbadc660fc4e85248af405acd67c025f11662bd4
Reviewed-on: https://chromium-review.googlesource.com/742657
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49042}
PR-URL: #18060
Fixes: #15386
Refs: v8/v8@c3458a8
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
When context is missing the executionAsyncId will be zero. For the default triggerAsyncId the zero value was used to default to the executionAsyncId. While this was not technically wrong because the functions are different themself, it poorly separated the two concepts. Backport-PR-URL: #18079 PR-URL: #17273 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Previously the getter would mutate the kDefaultTriggerAsncId value. This refactor changes the setter to bind the current kDefaultTriggerAsncId to a scope, such that the getter doesn't have to mutate its own value. Backport-PR-URL: #18079 PR-URL: #17273 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Switch over to async tracking through promises/async fns - Remove an unused temp dir refresh - Inline the multiline/npm text prompts into expectations - Unify handling prompts/stripping prompts out - Make sure no unexpected data is received by requireing all *lines* to be matched, rather than chunks received from the REPL. This made the test too loose in terms of matched lines and too strict in terms of stream chunking requirements. - Some general cleanup Backport-PR-URL: #18082 PR-URL: #17926 Reviewed-By: Evan Lucas <evanlucas@me.com>
common.fires() is specific to the inspector tests so move it to inspector-helper.js. The one REPL test that used common.fires() does not seem to need it. It provided a 1 second timeout for operations, but that timeout appears both arbitrary and ineffective as the test passes if it is reduced to even 1 millisecond. Backport-PR-URL: #18096 PR-URL: #17401 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Backport-PR-URL: #18102 PR-URL: #17924 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Backport-PR-URL: #18102 PR-URL: #17924 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This reverts commit 977fb13. This should not have landed on v9.x which does not yet support the feature PR-URL: #18141 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Communicate the current async stack length through a
typed array field rather than a native binding method
- Add a new fixed-size `async_ids_fast_stack` typed array
that contains the async ID stack up to a fixed limit.
This increases performance noticeably, since most of the time
the async ID stack will not be more than a handful of
levels deep.
- Make the JS `pushAsyncIds()` and `popAsyncIds()` functions
do the same thing as the native ones if the fast path
is applicable.
Benchmarks:
$ ./node benchmark/compare.js --new ./node --old ./node-master --runs 10 --filter next-tick process | Rscript benchmark/compare.R
[00:03:25|% 100| 6/6 files | 20/20 runs | 1/1 configs]: Done
improvement confidence p.value
process/next-tick-breadth-args.js millions=4 19.72 % *** 3.013913e-06
process/next-tick-breadth.js millions=4 27.33 % *** 5.847983e-11
process/next-tick-depth-args.js millions=12 40.08 % *** 1.237127e-13
process/next-tick-depth.js millions=12 77.27 % *** 1.413290e-11
process/next-tick-exec-args.js millions=5 13.58 % *** 1.245180e-07
process/next-tick-exec.js millions=5 16.80 % *** 2.961386e-07
Backport-PR-URL: #18290
PR-URL: #17780
Reviewed-By: James M Snell <jasnell@gmail.com>
The streams implementation generally ensures that only one write() call is active at a time. `JSStreamWrap` instances still kept queue of write reqeuests in spite of that; refactor it away. Also, fold `isAlive()` into a constant function on the native side. PR-URL: #17918 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Currently the cctest target build will fail if configured with --enable-static $ ./configure --enable-static $ make There're some function multiple definition errors such as: out/Release/obj.target/node/src/node_crypto.o: In function `node::crypto::RandomBytesWork(uv_work_s*)': node_crypto.cc:(.text+0x60): multiple definition of `node::crypto::RandomBytesWork(uv_work_s*)' out/Release/obj.target/node/src/node_crypto.o:node_crypto.cc:(.text+0x60): first defined here It's caused by repetition objects in libraries and libnode.a. This CL makes those libraries guarded by 'node_target_type!="static_library"'. PR-URL: #17992 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* use serial comma in child_process.md * use American spelling of unsanitized in child_process.md * hyphenate general-purpose in child_process.md * remove errant commas in child_process.md PR-URL: #17990 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #17988 Fixes: #17986 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
* remove spaces around slash in BUILDING.md * hyphenate _end-of-life_ in BUILDING.md * add missing comma in BUILDING.md * add missing backticks in BUILDING.md * add missing comma to BUILDING.md PR-URL: #17985 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This is made to mirror the connection-bound net benchmarks. PR-URL: #17983 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The API is required that `byte_length + byte_offset` is less than or equal to the size in bytes of the array passed in. If not, a RangeError exception is raised[1]. [1] https://nodejs.org/api/n-api.html#n_api_napi_create_dataview PR-URL: #17869 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #17379 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Not all shells set PWD, so use CURDIR instead. `which node` may return the empty string, so guard against that too. Consider: if [ -x `which velociraptor` ] && [ -e `which velociprator` ];\ then echo "run"; else echo "keep calm"; fi; PR-URL: #18040 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This is required because we need to add the babel-eslint dependency and it has to be able to resolve "eslint". babel-eslint is required to support future ES features such as async iterators and import.meta. Refs: #17755 PR-URL: #17820 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #17820 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Create tools/update-babel-eslint.sh script and execute it to do the first installation of the package. Update tools/license-builder.sh and execute it to add babel-eslint's license to our LICENSE file. PR-URL: #17820 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #17820 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #18018 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
PR-URL: #18018 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
The TLS implementation previously had two separate queues for WriteWrap instances, one for currently active and one for finishing writes (i.e. where the encrypted output is being written to the underlying socket). However, the streams implementation in Node doesn’t allow for more than one write to be active at a time; effectively, the only possible states were that: - No write was active. - The first write queue had one item, the second one was empty. - Only the second write queue had one item, the first one was empty. To reduce overhead and implementation complexity, remove these queues, and instead store a single `WriteWrap` pointer and keep track of whether its write callback should be called on the next invocation of `InvokeQueued()` or not (which is what being in the second queue previously effected). PR-URL: #17883 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #18291 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Currently, both process.binding and internalBinding have to call into C++ regardless of whether the module has been cached or not. This creates significant overhead to all binding calls and unfortunately the rest of the codebase doesn't really optimize the amount of times that bindings are required (as an example: 12 files require the async_wrap binding). Changing all the usage of this function throughout the codebase would introduce a lot of churn (and is kind of a hassle) so instead this PR introduces a JS fast path for both functions for cases where the binding has already been cached. While micro benchmarks are not super meaningful here (it's not like we call binding that often...), this does speed up the cached call by 400%. In addition, move moduleLoadList creation and management entirely into JS-land as it requires less code and is more efficient. PR-URL: #18365 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: #18432 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
PR-URL: #18282 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #18264 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Calling `writable.end()` will probably synchronously call `writable.write()`, in such a situation the `state.ended` is false and `writable.write()` doesn't trigger `writeAfterEnd()`. PR-URL: #18170 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
force-pushed
the
v9.5.0-proposal
branch
from
a88aa50
to
d665cf6
Compare
evanlucas
added a commit
that referenced
this pull request
Jan 30, 2018
Notable changes: * cluster - add cwd to cluster.settings (cjihrig) [#18399](#18399) * deps - upgrade libuv to 1.19.1 (cjihrig) [#18260](#18260) * meta - add Leko to collaborators (Leko) [#18117](#18117) - add vdeturckheim as collaborator (vdeturckheim) [#18432](#18432) * n-api - expose n-api version in process.versions (Michael Dawson) [#18067](#18067) * perf_hooks - add performance.clear() (James M Snell) [#18046](#18046) * stream - avoid writeAfterEnd() while ending (陈刚) [#18170](#18170) PR-URL: #18464
|
Trying CI again https://ci.nodejs.org/job/node-test-pull-request/12819/ |
|
@evanlucas Backport as required: #18474 – there were no conflicts you just had to apply the commits in the order they landed in master. |
cjihrig
approved these changes
Jan 31, 2018
The existing version of defaultTriggerAsyncIdScope creates an Array for the callback's arguments which is highly inefficient. Instead, use rest syntax and allow V8 to do that work for us. This yields roughly 2x performance for this particular function. Backport-PR-URL: #18474 PR-URL: #18004 Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This allows more easy tracking of where HTTP requests come from. Before this change the HTTPParser would have the HTTPServer as the triggerAsyncId. The HTTPParser will still have the executionAsyncId set to the HTTP Server so that information is still directly available. Indirectly, the TCP socket itself also has its triggerAsyncId set to the TCP Server. Backport-PR-URL: #18474 PR-URL: #18003 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
If IPv6 is not supported on a machine, the IPv6 handle will first be created, this will then fail and default to an IPv4 handle. This causes the graph to change, as there now is an extra handle. Backport-PR-URL: #18474 PR-URL: #18143 Fixes: #18003 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Notable changes: * cluster - add cwd to cluster.settings (cjihrig) [#18399](#18399) * deps - upgrade libuv to 1.19.1 (cjihrig) [#18260](#18260) * meta - add Leko to collaborators (Leko) [#18117](#18117) - add vdeturckheim as collaborator (vdeturckheim) [#18432](#18432) * n-api - expose n-api version in process.versions (Michael Dawson) [#18067](#18067) * perf_hooks - add performance.clear() (James M Snell) [#18046](#18046) * stream - avoid writeAfterEnd() while ending (陈刚) [#18170](#18170) PR-URL: #18464
evanlucas
force-pushed
the
v9.5.0-proposal
branch
from
d665cf6
to
5072454
Compare
|
Hopefully final CI: https://ci.nodejs.org/job/node-test-pull-request/12856/ If those look alright, I'll cut the release after those finish. Thanks! |
|
Hm, looks like ubuntu1604-arm64_odroid_c2 got an ICE on that last build...going to try one more to see if it reproduces... CI: https://ci.nodejs.org/job/node-test-pull-request/12861/ |
PR-URL: #18464
evanlucas
added a commit
that referenced
this pull request
Feb 1, 2018
Notable changes: * cluster - add cwd to cluster.settings (cjihrig) [#18399](#18399) * deps - upgrade libuv to 1.19.1 (cjihrig) [#18260](#18260) * meta - add Leko to collaborators (Leko) [#18117](#18117) - add vdeturckheim as collaborator (vdeturckheim) [#18432](#18432) * n-api - expose n-api version in process.versions (Michael Dawson) [#18067](#18067) * perf_hooks - add performance.clear() (James M Snell) [#18046](#18046) * stream - avoid writeAfterEnd() while ending (陈刚) [#18170](#18170) PR-URL: #18464
evanlucas
added a commit
to evanlucas/nodejs.org
that referenced
this pull request
Feb 1, 2018
evanlucas
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 1, 2018
|
Thanks @AndreasMadsen. I thought I had tried that already. |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Notable changes: * cluster - add cwd to cluster.settings (cjihrig) [nodejs#18399](nodejs#18399) * deps - upgrade libuv to 1.19.1 (cjihrig) [nodejs#18260](nodejs#18260) * meta - add Leko to collaborators (Leko) [nodejs#18117](nodejs#18117) - add vdeturckheim as collaborator (vdeturckheim) [nodejs#18432](nodejs#18432) * n-api - expose n-api version in process.versions (Michael Dawson) [nodejs#18067](nodejs#18067) * perf_hooks - add performance.clear() (James M Snell) [nodejs#18046](nodejs#18046) * stream - avoid writeAfterEnd() while ending (陈刚) [nodejs#18170](nodejs#18170) PR-URL: nodejs#18464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-01-31, Version 9.5.0 (Current), @evanlucas
Notable Changes
Commits
966f5a7e19] - (SEMVER-MINOR) stream: avoid writeAfterEnd() while ending (陈刚) #18170445f32d525] - stream: simplifysrc._readableStatetostate(陈刚) #182641f520975d5] - test: adds tests for vm invalid arguments (Gilles De Mey) #18282d4f3ebfe0f] - doc: add vdeturckheim as collaborator (vdeturckheim) #184323985667732] - process: JS fast path for bindings (Anatoli Papirovski) #183658c21566801] - src: remove outdated domain reference (Anatoli Papirovski) #1829107679f1015] - src: remove unnecessary block scope (Anatoli Papirovski) #182917fca45d043] - (SEMVER-MINOR) cluster: add cwd to cluster.settings (cjihrig) #183996f2f050034] - src: DRY ip address parsing code in cares_wrap.cc (Ben Noordhuis) #18398c0c160f088] - benchmark: implement duration in http test double (Joyee Cheung) #18380a7df729cfd] - benchmark: make compare.R easier to understand (Andreas Madsen) #1837353e0590ae0] - timers: attach listOnTimeout function to TimerWrap (Matteo Collina) #183885c3714663e] - doc: unify type linkification (Vse Mozhet Byt) #184079dcc4bd2ba] - src: remove unused variable (cjihrig) #183858ad1dcf8f6] - http: there is nocorkedproperty ofstream(Fedor Indutny) #18325851ff5cfac] - doc: fix typo in REPL docs (Adam Engebretson) #18404a0a659676e] - process: clean up signal handler setup (Anatoli Papirovski) #18330fa17a45f32] - process: remove dead code (Anatoli Papirovski) #1833061693f7b2c] - build: fix rm commands in tarball rule (Ben Noordhuis) #1833223554054df] - test: refactor addons-napi/test_exception/test.js (Rich Trott) #183403bc42d4216] - test: fix test-tls-server-verify.js on Windows CI (Rich Trott) #183821ef69e6860] - fs: cleanup fd lchown and lchownSync (James M Snell) #183292924d573a0] - doc: fix e.g., to e.g. in docs (sreepurnajasti) #1836916eca372db] - http2,perf_hooks: perf state using AliasedBuffer (Kyle Farnung) #18300e981c13d5d] - doc: fix documentation of http2Stream.pushstream() (Peter Dalgaard-Jensen) #182583a4dbbcc24] - doc: fix return value for require.resolve.paths() (Peter Dalgaard-Jensen) #18350cecbe44b1a] - test: use correct size in test-stream-buffer-list (Luigi Pinca) #18239e373834bf4] - stream: remove unreachable code (Luigi Pinca) #18239ccdffbb529] - (SEMVER-MINOR) lib: add internal removeColors helper (Ruben Bridgewater) #1761579af15dfbe] - doc: add missing word in modules.md (Robert Adamian) #1834346f39aedb2] - doc: add doc for performance.clearGC() (Antony Tran) #183312a7d6c073a] - doc: document the collaborator nomination process (Joyee Cheung) #182689ee2ca0c4a] - doc: improve the instructions of onboarding PR (Joyee Cheung) #1826833170ee34d] - (SEMVER-MINOR) deps: upgrade libuv to 1.19.1 (cjihrig) #18260cece39622c] - build: make lint-js independent of local node (Joyee Cheung) #18272602e542e0a] - build: make lint-md independent of local node (Joyee Cheung) #182722df81bf8f2] - doc: split CONTRIBUTING.md (Joyee Cheung) #182713fbbbd1a6e] - doc: fix typos in async_hooks (Matthew Turner) #183142d44487673] - build: define NOMINMAX on windows (Ben Noordhuis) #18216473dff53ef] - doc: add missing URL argument types in fs.md (Vse Mozhet Byt) #1830964de956041] - doc: remove confusing signature in fs.md (Vse Mozhet Byt) #18310cd76e6e3f7] - test: change assert message to default (ryanmahan) #18259fdaeed915b] - benchmark: use destructuring (Ruben Bridgewater) #18250a43d7006bc] - benchmark: (dgram) use destructuring (Ruben Bridgewater) #18250714c3ba94d] - benchmark: (child_process) use destructuring (Ruben Bridgewater) #18250f6ddc863b1] - benchmark: (buffers) use destructuring (Ruben Bridgewater) #182508a6c41309b] - benchmark: (events) use destructuring (Ruben Bridgewater) #1825062f0d0e60d] - benchmark: (es) use destructuring (Ruben Bridgewater) #18250ff8cce5f3f] - benchmark: (fs) use destructuring (Ruben Bridgewater) #18250fa1924caae] - benchmark: (http) use destructuring (Ruben Bridgewater) #182507d15acb782] - benchmark: (misc) use destructuring (Ruben Bridgewater) #182504ae0630a82] - benchmark: (http2) use destructuring (Ruben Bridgewater) #18250d341c9eeea] - benchmark: (string_decoder) use destructuring (Ruben Bridgewater) #182506593a76cbf] - benchmark: (path) use destructuring (Ruben Bridgewater) #1825022fa4faa5c] - benchmark: (os) use destructuring (Ruben Bridgewater) #182500f5c232e89] - benchmark: (net) use destructuring (Ruben Bridgewater) #182508215d2c9e3] - benchmark: (process) use destructuring (Ruben Bridgewater) #1825027aca90b70] - benchmark: (querystring) use destructuring (Ruben Bridgewater) #182509cf98da23e] - benchmark: (streams) use destructuring (Ruben Bridgewater) #18250135b79a84e] - benchmark: (timers) use destructuring (Ruben Bridgewater) #18250765191972f] - benchmark: (tls) use destructuring (Ruben Bridgewater) #182505dbca75a46] - benchmark: (util/v8/vm) use destructuring (Ruben Bridgewater) #18250d9e26d495b] - benchmark: (zlib) use destructuring (Ruben Bridgewater) #182501dab4491c4] - benchmark: (url) use destructuring (Ruben Bridgewater) #18250248210223d] - benchmark: (assert) use destructuring (Ruben Bridgewater) #182503c4d7e70ea] - benchmark: (arrays) use destructuring (Ruben Bridgewater) #1825008686a5ba1] - doc: use PBKDF2 in text (Tobias Nießen) #1827969de76b45f] - doc: fix typo in async_hooks.md (Matthew Turner) #182869ad45ef710] - lib: fix typo in trace_events_async_hooks.js (Gilles De Mey) #18280fd3aa03668] - http: use strict comparison (leeseean) #17011aa96858dbb] - test: use countdown timer (Mandeep Singh) #173267bebb0d988] - http: free the parser before emitting 'upgrade' (Luigi Pinca) #182094b6297aa76] - doc: Add example of null to assert.ifError (Leko) #182363b9ef2142c] - http: fix parsing of binary upgrade response body (Ben Noordhuis) #178067a7e1309d4] - test: make async-wrap-getasyncid parallelizable (Joyee Cheung) #18245ff6e73a976] - doc: improve process.platform (Mars Wong) #18057e396c4cb67] - doc: cjs format is now commonjs (Gus Caplan) #181659c16171674] - http2: add checks for server close callback (James M Snell) #18182913236744a] - src: fix -Wimplicit-fallthrough warning (Ben Noordhuis) #182059d0d526e74] - build: remove unused vars from configure (Ben Noordhuis) #18206c735c991a9] - lib: use american spelling as per style guide (sreepurnajasti) #182260b6eab556e] - test: refactor test-http-parser (Jon Moss) #1821920734dc53c] - benchmark: remove redundant + (sreepurnajasti) #1780397775f1f03] - http: simplify parser lifetime tracking (Anna Henningsen) #18135e22602f3b9] - src: refactor callback #defines into C++ templates (Anna Henningsen) #181332b13fda65c] - test: add assertions for TextEncoder/Decoder (Sho Miyamoto) #18132aee8be91b3] - http2: refactor read mechanism (Anna Henningsen) #180307219a13f08] - src: introduce internal buffer slice constructor (Anna Henningsen) #18030f25cba3a40] - doc: V8 branch used in 8.x not active anymore (Franziska Hinkelmann) #181558b2eefd65f] - doc: add change info for async_hooks.executionAsyncId() (Stephen Belanger) #17813e7e85246b3] - doc: remove uannecessary Require (Michael Dawson) #18184da2b335985] - doc: add builtin module in building.md (Suixinlei) #1770535ef067097] - doc: warn users about non-ASCII paths on build (Matheus Marchini) #16735302b3eed6d] - doc: add missing link references (Vse Mozhet Byt) #18222a1096a6b05] - doc: simplify sentences that use "considered" (Rich Trott) #18095778d57c2c2] - fs: fix options.end of fs.ReadStream() (陈刚) #181211d74c33148] - doc: update sample output for process.versions (Michael Dawson) #181672fb5f19894] - doc: fix typo in TextEncoding section (Yosuke Furukawa) #182013299a1a19b] - test: remove trivial buffer imports (sreepurnajasti) #1803478e05da071] - test: use shorthand properties (Tobias Nießen) #1810563be0d6daa] - test: simplify loadDHParam in TLS test (Tobias Nießen) #181036b687cf3c9] - cluster: resolve relative unix socket paths (laino) #16749f81c62246d] - build: refine static and shared lib build (Yihong Wang) #176042c4e0216de] - build,win: update lint-cpp on Windows (Kyle Farnung) #180121dcae5756e] - test: improve to use template string (sreepurnajasti) #18097b4e7260d3e] - doc: fix typo in http2stream.close param default (Moritz Peters) #181660c8b5d5bfb] - test: fixed typos in napi test (furstenheim) #18148217ddd8ba2] - src,doc,test: Fix common misspellings (Roman Reiss) #181519edf023694] - n-api: throw RangeError napi_create_typedarray() (Jinho Bang) #18037b05f09a587] - doc: suggest not to throw JS errors from C++ (Joyee Cheung) #181491506eb5f25] - build: remove bench-* targets (Joyee Cheung) #181505a95905d91] - doc: napi: make header style consistent (Ali Ijaz Sheikh) #18122990abbf06c] - doc: napi: fix unbalanced emphasis (Ali Ijaz Sheikh) #1812287e3d3db89] - src: fix code coverage cleanup (Michael Dawson) #1808115aaf18b72] - src: remove declarations for missing functions (Anna Henningsen) #18134ac0a0a6775] - src: harden JSStream callbacks (Anna Henningsen) #180282aeb025999] - test: add common.crashOnUnhandledRejection to addons/callback-scope (Sho Miyamoto) #18076f8f809b7fa] - doc: add documentation for deprecation properties (Jon Moss) #165390e8596e2a6] - doc: prefer make test-only when verifying the build (Joyee Cheung) #18061bbdc3c4ae8] - doc: add Leko to collaborators (Leko) #18117afc30a56e3] - doc: decapitalize primitive types (Vse Mozhet Byt) #181100668a75c39] - (SEMVER-MINOR) n-api: expose n-api version in process.versions (Michael Dawson) #18067d8ac817cb6] - build,win: restore vcbuild TAG functionality (Rod Vagg) #18031eee40c71c9] - http2: remember sent headers (James M Snell) #18045645be73b9d] - (SEMVER-MINOR) perf_hooks,http2: add performance.clear() (James M Snell) #1804630e2221a15] - doc: fix s/rstStream/close in example (James M Snell) #180881c81a055df] - doc: update pushStream docs to use err first (James M Snell) #180887706e5f1ea] - test: remove orphaned entries from status (Kyle Farnung) #18092de70a363eb] - doc: be less tentative about undefined behavior (Rich Trott) #1809196b072233a] - tls: refactor write queues away (Anna Henningsen) #17883dcdb646ada] - lib: fix spelling in comments (Tobias Nießen) #180185fccb6ea3a] - test: fix spelling in test case comments (Tobias Nießen) #18018be9958afb6] - tools: use babel-eslint as ESLint parser (Michaël Zasso) #17820715e673d06] - tools: add babel-eslint (Michaël Zasso) #17820d349fcae11] - tools: update ESLint to 4.15.0 (Michaël Zasso) #178204bc4d004b1] - tools: move eslint from tools to tools/node_modules (Michaël Zasso) #17820969c89bf55] - build: fix Makefile wrt finding node executable (Yang Guo) #18040470832f203] - path: fix path.normalize for relative paths (Weijia Wang) #179745ebd0178a6] - doc: add descriptions of state properties (James M Snell) #180447911b9b493] - doc: examples for fast-tracking regression fixes (Refael Ackermann) #17379f693e81ee5] - n-api: throw RangeError in napi_create_dataview() with invalid range (Jinho Bang) #17869a4ba791566] - benchmark: add JSStreamWrap benchmark (Anna Henningsen) #17983f0a0fdd83a] - doc: multiple updates to BUILDING.md (Rich Trott) #179853456e61b44] - test: use smaller input file for test-zlib.js (Rich Trott) #17988278450fc72] - doc: multiple updates to child_process.md (Rich Trott) #17990dd72f9c9b7] - build: fix cctest target with --enable-static (Qingyan Li) #179928f8e7479cb] - lib: remove queue implementation from JSStreamWrap (Anna Henningsen) #17918dd56bd1591] - async_hooks: use typed array stack as fast path (Anna Henningsen) #17780722fe464bc] - Revert "doc: import() is supported now" (Myles Borins) #1814156a9ae7773] - readline: update references to archived repository (Tobias Nießen) #17924733df362fa] - test: update references to archived repository (Tobias Nießen) #17924df8cb401a0] - errors: remove ERR_OUTOFMEMORY (Tobias Nießen) #178772eb1aa81fa] - test: move common.fires() to inspector-helper (Rich Trott) #17401167e9c6dcd] - test: refactor test-repl (Anna Henningsen) #17926a880e272ff] - async_hooks: use scope for defaultTriggerAsyncId (Andreas Madsen) #17273f56eb2a41e] - async_hooks: separate missing from default context (Andreas Madsen) #172732a4f849c39] - async_hooks: rename initTriggerId (Andreas Madsen) #17273506d85bfba] - deps: cherry-pick c3458a8 from upstream V8 (Michaël Zasso) #1806039970e9caf] - doc: un-mark Socket#write “removal” as notable change (Anna Henningsen) #18083