Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary timer #18719

Merged
merged 1 commit into from
Feb 14, 2018
Merged

test: remove unnecessary timer #18719

merged 1 commit into from
Feb 14, 2018

Commits on Feb 14, 2018

  1. test: remove unnecessary timer

    The timer in NAPI's test_callback_scope/test-resolve-async.js
    can be removed. If the test fails, it will timeout on its own.
    The extra timer increases the chances of the test being
    flaky.
    
    PR-URL: nodejs#18719
    Fixes: nodejs#18702
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    755e07c View commit details
    Browse the repository at this point in the history