n-api: fix object test #19039
Closed
n-api: fix object test #19039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v4.x
node-api
cjihrig
approved these changes
Feb 27, 2018
| @@ -199,7 +198,7 @@ napi_value Wrap(napi_env env, napi_callback_info info) { | |||
| napi_value arg; | |||
| NAPI_CALL(env, napi_get_cb_info(env, info, &argc, &arg, NULL, NULL)); | |||
|
|
|||
| int32_t* data = malloc(sizeof(int32_t)); | |||
| int32_t* data = &test_value; | |||
| *data = test_value; | |||
There was a problem hiding this comment.
Isn't this line redundant now?
|
Yeah, I'll get rid of it altogether.
…On Tue, Feb 27, 2018 at 2:08 PM, Colin Ihrig ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In test/addons-napi/test_object/test_object.c
<#19039 (comment)>:
> @@ -199,7 +198,7 @@ napi_value Wrap(napi_env env, napi_callback_info info) {
napi_value arg;
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, &arg, NULL, NULL));
- int32_t* data = malloc(sizeof(int32_t));
+ int32_t* data = &test_value;
*data = test_value;
Isn't this line redundant now?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19039 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA7k0QsMmy7jfk7aXglqHPca_MLXyjpNks5tZFKcgaJpZM4SVZVn>
.
|
Passing a pointer to a static integer is sufficient for the test.
gabrielschulhof
force-pushed
the
n-api-fix-test-object
branch
from
6bba350
to
b0f7927
Compare
digitalinfinity
approved these changes
Feb 27, 2018
|
CI https://ci.nodejs.org/job/node-test-pull-request/13425/ @gabrielschulhof please always start a CI after opening a PR :-) |
BridgeAR
added
the
author ready
|
Landed in c698017. |
gabrielschulhof
pushed a commit
that referenced
this pull request
Mar 2, 2018
Passing a pointer to a static integer is sufficient for the test. PR-URL: #19039 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Mar 5, 2018
Passing a pointer to a static integer is sufficient for the test. PR-URL: nodejs#19039 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Merged
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 12, 2018
Passing a pointer to a static integer is sufficient for the test. PR-URL: nodejs#19039 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 16, 2018
Passing a pointer to a static integer is sufficient for the test. PR-URL: nodejs#19039 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Merged
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Passing a pointer to a static integer is sufficient for the test. PR-URL: nodejs#19039 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a pointer to a static integer is sufficient for the test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
n-api