Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix n-api asynchronous threading documentation #19073

Closed
wants to merge 3 commits into from

Commits on Mar 1, 2018

  1. doc: fix n-api asynchronous threading documentation

    Documentation for N-API Custom Asynchronous Operations incorrectly
    stated that async execution happens on the main event loop.
    Added details to napi_create_async_work about which threads are
    used to invoke the execute and complete callbacks.
    
    Fixes: nodejs#19071
    ebickle committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    ab63ce5 View commit details
    Browse the repository at this point in the history
  2. doc: fix typo in napi_create_async_work documentation

    Documentation for napi_create_async_work was missing part of the word "completed" in the parameter documentation
    ebickle committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    f59ea55 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. doc: remove async abbreviation and clarify threading behavior

    Changed 'async' to 'asynchronous' in the documentation for Custom Asynchronous Operations. Changed "executes in parallel" to "can execute in parallel" for the documentation of napi_create_async_work execute parameter.
    ebickle committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    3493aa9 View commit details
    Browse the repository at this point in the history