Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: simplify timeout tracking #19206

Closed
wants to merge 1 commit into from
Closed

http2: simplify timeout tracking #19206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/node_http2.cc
View file
Open in desktop
Expand Up @@ -1630,10 +1630,6 @@ inline Http2Stream* Http2Session::SubmitRequest(
return stream;
}

inline void Http2Session::SetChunksSinceLastWrite(size_t n) {
chunks_sent_since_last_write_ = n;
}

// Callback used to receive inbound data from the i/o stream
void Http2Session::OnStreamRead(ssize_t nread, const uv_buf_t& buf) {
Http2Scope h2scope(this);
Expand Down Expand Up @@ -2016,7 +2012,6 @@ inline int Http2Stream::DoWrite(WriteWrap* req_wrap,
CHECK(!this->IsDestroyed());
CHECK_EQ(send_handle, nullptr);
Http2Scope h2scope(this);
session_->SetChunksSinceLastWrite();
if (!IsWritable()) {
req_wrap->Done(UV_EOF);
return 0;
Expand Down Expand Up @@ -2519,8 +2514,6 @@ void Http2Stream::RespondFD(const FunctionCallbackInfo<Value>& args) {
int64_t length = args[3]->IntegerValue(context).ToChecked();
int options = args[4]->IntegerValue(context).ToChecked();

stream->session()->SetChunksSinceLastWrite();

Headers list(isolate, context, headers);
args.GetReturnValue().Set(stream->SubmitFile(fd, *list, list.length(),
offset, length, options));
Expand Down
2 changes: 0 additions & 2 deletions src/node_http2.h
View file
Open in desktop
Expand Up @@ -884,8 +884,6 @@ class Http2Session : public AsyncWrap, public StreamListener {
// Write data to the session
inline ssize_t Write(const uv_buf_t* bufs, size_t nbufs);

inline void SetChunksSinceLastWrite(size_t n = 0);

size_t self_size() const override { return sizeof(*this); }

inline void GetTrailers(Http2Stream* stream, uint32_t* flags);
Expand Down