Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: shared lib build doesn't handle SIGPIPE #19211

Closed
wants to merge 1 commit into from
Closed

test: shared lib build doesn't handle SIGPIPE #19211

wants to merge 1 commit into from

Commits on Mar 9, 2018

  1. test: shared lib build doesn't handle SIGPIPE 

    For shared lib build, we leave the signal handling for embedding users.
In these two test cases:
- `parallel/test-process-external-stdio-close-spawn`
- `parallel/test-process-external-stdio-close`

The pipe is used for stdout and is destroied before child process uses
it for logging. So the node executble that uses shared lib build
receives SIGPIPE and the child process ends.

This change ignores the SIGPIPE in node_main.cc for shared lib case.

Refs: nodejs#18535

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
    @yhwang
    yhwang committed Mar 9, 2018
    Copy the full SHA
    4a7be07 View commit details
    Browse the repository at this point in the history