Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: add missing exception checking #19362

Closed
wants to merge 1 commit into from
Closed

n-api: add missing exception checking #19362

wants to merge 1 commit into from

Commits on Mar 15, 2018

  1. n-api: add missing exception checking 

    Add checks for a pending exception in napi_make_callback
after the callback has been invoked.  If there is a pending
exception then we need to avoid checking the result as that
will not be able to complete properly.

Add additional checks to the unit test for napi_make_callback
to catch this case.

Fixes: nodejs/node-addon-api#235
    @mhdawson
    mhdawson committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    d181f7f View commit details
    Browse the repository at this point in the history