Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove n-api intermediate files #19375

Conversation

gabrielschulhof
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Mar 15, 2018
@lpinca
Copy link
Member

lpinca commented Mar 18, 2018

I think base branch should be v6.x-staging but it probably doesn't matter.

Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
PR-URL: #19375
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins
Copy link
Member

landed in dfbad37

MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
PR-URL: #19375
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
PR-URL: #19375
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 13, 2018
@gabrielschulhof gabrielschulhof deleted the v6.x-remove-napi-test-intermediates branch April 28, 2018 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants