Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] http: make socketPath work with no agent #19425

Closed

Commits on Mar 31, 2018

  1. http: make socketPath work with no agent

    Currently `Agent.prototype.createConnection()` is called uncoditionally
    if the `socketPath` option is used. This throws an error if no agent is
    used, preventing, for example, the `socketPath` and `createConnection`
    options to be used together.
    
    This commit fixes the issue by falling back to the `createConnection`
    option or `net.createConnection()`.
    lpinca committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    6cc1820 View commit details
    Browse the repository at this point in the history