Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: bump version of n-api supported #19497

Closed
wants to merge 1 commit into from
Closed

n-api: bump version of n-api supported #19497

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

Bump the version due to additions to the api.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mhdawson
n-api: bump version of n-api supported
c28a7b1 
Bump the version due to additions to the api.
@mhdawson mhdawson mentioned this pull request Mar 20, 2018
Closed
4 tasks
@mhdawson
Copy link
Member Author

Only backport this if one of the PRs that adds APIs is backported. For example #19337. When it is backported we'll need to capture the PRs adding APIs that went along with it, and make sure we only backport to versions where all of those APIs are supported.

@mhdawson mhdawson added semver-minor PRs that contain new features and should be released in the next minor version. node-api Issues and PRs related to the Node-API. dont-land-on-v4.x labels Mar 20, 2018
@mhdawson
Copy link
Member Author

CI run: https://ci.nodejs.org/job/node-test-pull-request/13839/

@mhdawson mhdawson added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2018
@BridgeAR
Copy link
Member

Landed in 6572f63 🎉

@BridgeAR BridgeAR closed this Mar 27, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 27, 2018
@mhdawson @BridgeAR
n-api: bump version of n-api supported
6572f63 
Bump the version due to additions to the api.

PR-URL: nodejs#19497
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Apr 2, 2018
@mhdawson @targos
n-api: bump version of n-api supported
94a10ba 
Bump the version due to additions to the api.

PR-URL: #19497
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit that referenced this pull request Apr 4, 2018
@targos
2018-04-04, Version 9.11.0 (Current)
11c8db4 
Notable changes:

* deps:
  - Updated ICU to 61.1 (Steven R. Loomis)
    [#19621](#19621)
    Includes CLDR 33 (many new languages and data improvements).
* fs:
  - Emit 'ready' event for `ReadStream` and `WriteStream` (Sameer
    Srivastava) [#19408](#19408)
* n-api:
  - Bump version of n-api supported (Michael Dawson)
    [#19497](#19497)
* net:
  - Emit 'ready' event for `Socket` (Sameer Srivastava)
    [#19408](#19408)
* Added new collaborators
  - [mafintosh](https://github.com/mafintosh) Mathias Buus
@targos targos mentioned this pull request Apr 4, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Apr 4, 2018
@targos @MylesBorins
2018-04-04, Version 9.11.0 (Current)
67cce8d 
Notable changes:

* deps:
  - Updated ICU to 61.1 (Steven R. Loomis)
    [#19621](#19621)
    Includes CLDR 33 (many new languages and data improvements).
* fs:
  - Emit 'ready' event for `ReadStream` and `WriteStream` (Sameer
    Srivastava) [#19408](#19408)
* n-api:
  - Bump version of n-api supported (Michael Dawson)
    [#19497](#19497)
* net:
  - Emit 'ready' event for `Socket` (Sameer Srivastava)
    [#19408](#19408)
* Added new collaborators
  - [mafintosh](https://github.com/mafintosh) Mathias Buus
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 12, 2018
@mhdawson
n-api: bump version of n-api supported
c33daa4 
Bump the version due to additions to the api.

PR-URL: nodejs#19497
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
@mhdawson
n-api: bump version of n-api supported
96fe46b 
Bump the version due to additions to the api.

PR-URL: nodejs#19497
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@mhdawson @MylesBorins
n-api: bump version of n-api supported
c6d0a66 
Bump the version due to additions to the api.

Backport-PR-URL: #19447
PR-URL: #19497
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 1, 2018
@mhdawson @MylesBorins
n-api: bump version of n-api supported
367113f 
Bump the version due to additions to the api.

Backport-PR-URL: #19265
PR-URL: #19497
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
@mhdawson mhdawson deleted the n-api-version branch September 30, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. node-api Issues and PRs related to the Node-API. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mhdawson @BridgeAR @jasnell @cjihrig @trivikr