test: removed unhelpful message from assert.strictEqual() calls #19525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted the 'message' argument values from the last two free socket assert.strictEqual() calls to code comments as they fail to provide the necessary details and values specific to why the test is failing. The default message returned from the strictEqual() call should provide sufficient details for debugging errors.
Trott
approved these changes
Mar 22, 2018
danbev
approved these changes
Mar 22, 2018
cjihrig
approved these changes
Mar 22, 2018
trivikr
approved these changes
Mar 22, 2018
richardlau
approved these changes
Mar 22, 2018
jasnell
approved these changes
Mar 23, 2018
|
CI failures appear unrelated. ARM fanned re-run: https://ci.nodejs.org/job/node-test-commit-arm-fanned/15342/ pLinux re-run: https://ci.nodejs.org/job/node-test-commit-plinux/16259/ |
|
Hi @Trott, anything else needed from me to get this merged? Can we just re-run the node-test-pull-request job or do I need changes on my end? |
|
CI re-runs were green so this can land once it's been open for 72 hours (so in another 4 hours from now) as long as no Collaborator comes along with an objection. |
Trott
added
the
author ready
|
Awesome! Thanks, @Trott! |
|
Oh, it only needs 48 hours because it was opened on a Wednesday (in my timezone, anyway--our 48/72 week/weekend rule has some ambiguity). I'll land now. |
|
Meh, our tooling is telling me to wait 3 more hours. I'll defer to the tooling. Sorry for all the comment noise. |
|
All good. Thanks for keeping me updated! |
trivikr
pushed a commit
that referenced
this pull request
Mar 25, 2018
Converted the 'message' argument values from the last two free socket assert.strictEqual() calls to code comments as they fail to provide the necessary details and values specific to why the test is failing. The default message returned from the strictEqual() call should provide sufficient details for debugging errors. PR-URL: #19525 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in d101942 @willhayslett Congratulations on your first commit in Node.js core! 🎉 |
|
Whew! Thanks, @trivikr! |
targos
pushed a commit
that referenced
this pull request
Mar 27, 2018
Converted the 'message' argument values from the last two free socket assert.strictEqual() calls to code comments as they fail to provide the necessary details and values specific to why the test is failing. The default message returned from the strictEqual() call should provide sufficient details for debugging errors. PR-URL: #19525 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 3, 2018
Converted the 'message' argument values from the last two free socket assert.strictEqual() calls to code comments as they fail to provide the necessary details and values specific to why the test is failing. The default message returned from the strictEqual() call should provide sufficient details for debugging errors. PR-URL: #19525 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted the 'message' argument values from the last two free socket
assert.strictEqual() calls to code comments as they fail to provide the
necessary details and values specific to why the test is failing. The
default message returned from the strictEqual() call should provide
sufficient details for debugging errors.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes