Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve assert legacy text #19622

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 26, 2018

This changes a sentence fragment into a full sentence and provides a few
other minor improvements.

Checklist

This changes a sentence fragment into a full sentence and provides a few
other minor improvements.
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Mar 26, 2018
@Trott
Copy link
Member Author

Trott commented Mar 26, 2018

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 26, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 27, 2018
This changes a sentence fragment into a full sentence and provides a few
other minor improvements.

PR-URL: nodejs#19622
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

Landed in 12f69dd 🎉

@BridgeAR BridgeAR closed this Mar 27, 2018
targos pushed a commit that referenced this pull request Mar 27, 2018
This changes a sentence fragment into a full sentence and provides a few
other minor improvements.

PR-URL: #19622
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Dec 4, 2018
This changes a sentence fragment into a full sentence and provides a few
other minor improvements.

PR-URL: #19622
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
@Trott Trott deleted the sentence-fragment branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants