Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-net-dns-error #19640

Closed
wants to merge 1 commit into from
Closed

test: refactor test-net-dns-error #19640

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Mar 27, 2018 •
edited

  • Use common.mustCall() and common.mustNotCall().
  • Use ternary operator.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@lpinca
test: refactor test-net-dns-error
9e1ffbb 
- Use `common.mustCall()` and `common.mustNotCall()`.
- Use ternary operator.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 27, 2018
@lpinca
Copy link
Member Author

lpinca commented Mar 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13893/

@lpinca
Copy link
Member Author

lpinca commented Mar 29, 2018

Landed in 37db277.

lpinca added a commit that referenced this pull request Mar 29, 2018
@lpinca
test: refactor test-net-dns-error
37db277 
- Use `common.mustCall()` and `common.mustNotCall()`.
- Use ternary operator.

PR-URL: #19640
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca lpinca closed this Mar 29, 2018
@lpinca lpinca deleted the refactor/test-net-dns-error branch March 29, 2018 10:56
targos pushed a commit that referenced this pull request Apr 2, 2018
@lpinca @targos
test: refactor test-net-dns-error
a89ba21 
- Use `common.mustCall()` and `common.mustNotCall()`.
- Use ternary operator.

PR-URL: #19640
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Apr 4, 2018
Merged
BethGriggs pushed a commit that referenced this pull request Dec 4, 2018
@lpinca @BethGriggs
test: refactor test-net-dns-error
a62df1b 
- Use `common.mustCall()` and `common.mustNotCall()`.
- Use ternary operator.

PR-URL: #19640
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lpinca @jasnell @Trott @cjihrig @richardlau @trivikr @nodejs-github-bot