Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix a typo in lib/timers: read though -> read through #19666

Closed
wants to merge 1 commit into from
Closed

lib: fix a typo in lib/timers: read though -> read through #19666

wants to merge 1 commit into from
+1 −1

Conversation

adispring
Copy link
Contributor

fix a typo in ./lib/timers.js: read though -> read through

Checklist

Sorry, something went wrong.

@adispring
lib: fix a typo in lib/timers: read though -> read through

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
GPG key ID: EBB0EA4124809D02
Expired
Verified
Learn about vigilant mode
572e330
@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Mar 29, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 29, 2018
vsemozhetbyt
vsemozhetbyt approved these changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/354/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2018
@trivikr
Copy link
Member

trivikr commented Mar 29, 2018

Landed in 108c176

@trivikr trivikr closed this Mar 29, 2018
trivikr pushed a commit that referenced this pull request Mar 29, 2018
@adispring @trivikr
lib: fix a typo in lib/timers "read through"

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
GPG key ID: EBB0EA4124809D02
Expired
Verified
Learn about vigilant mode
108c176 
PR-URL: #19666
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@trivikr
Copy link
Member

trivikr commented Mar 29, 2018

Congrats @adispring for your first contribution to Node.js core! 🎉🎉🎉

targos pushed a commit that referenced this pull request Apr 2, 2018
@adispring @targos
lib: fix a typo in lib/timers "read through"

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
889a3b4 
PR-URL: #19666
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Apr 4, 2018
Merged
BethGriggs pushed a commit that referenced this pull request Dec 4, 2018
@adispring @BethGriggs
lib: fix a typo in lib/timers "read through"
8afbd5c 
PR-URL: #19666
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt

@trivikr trivikr

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adispring @vsemozhetbyt @trivikr @nodejs-github-bot