Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test process.setuid for bad argument types #19703

Closed
wants to merge 1 commit into from
Closed

test: test process.setuid for bad argument types #19703

wants to merge 1 commit into from

Conversation

dsinecos
Copy link
Contributor

test process.setuid with an object as an argument. An equivalent test
exists for process.seteuid

Fixes: #19591

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@dsinecos
test: test process.setuid for bad argument types
6bf36f0 
test process.setuid with an object as an argument. An equivalent test
exists for process.seteuid

Fixes: nodejs#19591
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 30, 2018
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/13948/

@lpinca
Copy link
Member

lpinca commented Apr 2, 2018

New CI: https://ci.nodejs.org/job/node-test-pull-request/13987/

@lpinca
Copy link
Member

lpinca commented Apr 4, 2018

Landed in 83444b7.

@lpinca lpinca closed this Apr 4, 2018
lpinca pushed a commit that referenced this pull request Apr 4, 2018
@dsinecos @lpinca
test: test process.setuid for bad argument types
83444b7 
Test process.setuid with an object as an argument. An equivalent test
exists for process.seteuid.

PR-URL: #19703
Fixes: #19591
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 4, 2018
@dsinecos @targos
test: test process.setuid for bad argument types
92e9ed0 
Test process.setuid with an object as an argument. An equivalent test
exists for process.seteuid.

PR-URL: #19703
Fixes: #19591
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Apr 4, 2018
Merged
BethGriggs pushed a commit that referenced this pull request Dec 4, 2018
@dsinecos @BethGriggs
test: test process.setuid for bad argument types
5e09a3d 
Test process.setuid with an object as an argument. An equivalent test
exists for process.seteuid.

PR-URL: #19703
Fixes: #19591
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: Test process.setuid for bad argument types
7 participants
@dsinecos @gireeshpunathil @lpinca @jasnell @cjihrig @trivikr @nodejs-github-bot