Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove squash guideline from onboarding doc #20413

Closed
wants to merge 3 commits into from
Closed

doc: remove squash guideline from onboarding doc #20413

wants to merge 3 commits into from

Commits on Apr 30, 2018

  1. doc: remove squash guideline from onboarding doc 

    Although I agree with the guideline people should generally not squash
commits in a pull request until the end (in other words, until it's time
to land the PR), it is clear from comments and actions in the issue
tracker that many do not share that view. This is fine by me, but I do
think that we should our documentation should reflect our practices
rather than being an aspirational statement.

If we *do* wish to preserve this recommendation, it probably belongs in
another document anyway as this is not a recommendation for
Collaborators only but for anyone opening a pull request.
    @Trott
    Trott committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    09cb507 View commit details
    Browse the repository at this point in the history

  2. doc: add squash guideline to pull-requests doc 

    Tell the contributor to generally not squash commits during the pull
request review process.
    @Trott
    Trott committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    6fe0af1 View commit details
    Browse the repository at this point in the history

  3. squash! minor typographical fix

    @Trott
    Trott committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    be7118e View commit details
    Browse the repository at this point in the history