Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix cctest build failure in Windows #21228

Closed
wants to merge 1 commit into from
Closed

build: fix cctest build failure in Windows #21228

wants to merge 1 commit into from

Commits on Jul 24, 2018

  1. build: skip cctest on Windows shared lib build 

    cctest depends on some internal APIs which don't declare
`__declspec(dllexport)` and causes build failure when building
node as shared lib on Windows. Since we already have good test
coverage in static lib, we decide to skip the cctest in shared
lib build on Windows.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
    @yhwang
    yhwang committed Jul 24, 2018
    Copy the full SHA
    0ec2e1d View commit details
    Browse the repository at this point in the history