Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests,aix: avoid running fsync on directory #21298

Closed
wants to merge 1 commit into from
Closed

tests,aix: avoid running fsync on directory #21298

wants to merge 1 commit into from

Conversation

jBarz
Copy link
Contributor

@jBarz jBarz commented Jun 13, 2018 •
edited

The underlying fsync system call returns EBADF on a file descriptor
for an open directory. So avoid running fsync on it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 13, 2018
@jBarz
tests,aix: avoid running fsync on directory
d28958a 
The underlying fsync system call returns EBADF on a file descriptor
for an open directory. So avoid running fsync on it.
richardlau
richardlau reviewed Jun 13, 2018
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes look okay, but this behaviour should probably be documented.

Is the underlying fsync call in libuv and, if so, should it be handled/documented there?

@jBarz
Copy link
Contributor Author

jBarz commented Jun 13, 2018

Yea, the fsync call is in libuv. I can document it in libuv if that is ok

@trivikr trivikr added the aix Issues and PRs related to the AIX platform. label Jun 13, 2018
@richardlau
Copy link
Member

For reference, libuv doc PR: libuv/libuv#1879

mhdawson
mhdawson approved these changes Jun 13, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/15459/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 14, 2018
cjihrig pushed a commit to libuv/libuv that referenced this pull request Jun 19, 2018
@jBarz @cjihrig
doc: add uv_fs_fsync() AIX limitations
8ab14e2 
Unlike other platforms, the fsync call on aix will not accept
non-regular file file-descriptors.

Refs: nodejs/node#21298
PR-URL: #1879
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@jBarz
Copy link
Contributor Author

jBarz commented Jun 22, 2018

I think this is good to go.

@richardlau richardlau self-assigned this Jun 22, 2018
richardlau pushed a commit that referenced this pull request Jun 22, 2018
@jBarz @richardlau
test: avoid running fsync on directory on AIX
8689c78 
On AIX the underlying fsync system call returns EBADF on a file
descriptor for an open directory. So avoid running fsync on it.

PR-URL: #21298
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau
Copy link
Member

Amended commit message and landed in 8689c78.

@richardlau richardlau closed this Jun 22, 2018
targos pushed a commit that referenced this pull request Jun 24, 2018
@jBarz @targos
test: avoid running fsync on directory on AIX
6b40ba1 
On AIX the underlying fsync system call returns EBADF on a file
descriptor for an open directory. So avoid running fsync on it.

PR-URL: #21298
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
BethGriggs pushed a commit that referenced this pull request Mar 21, 2019
@jBarz @BethGriggs
test: avoid running fsync on directory on AIX
3128cb7 
On AIX the underlying fsync system call returns EBADF on a file
descriptor for an open directory. So avoid running fsync on it.

PR-URL: #21298
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

@richardlau richardlau

Labels
aix Issues and PRs related to the AIX platform. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jBarz @richardlau @addaleax @jasnell @cjihrig @gireeshpunathil @mhdawson @trivikr @nodejs-github-bot