Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: don't bind to 0.0.0.0 by default (v6.x) #21376

Closed
wants to merge 4 commits into from

Commits on Jun 14, 2018

  1. tools,gyp: fix regex for version matching

    Tool versions can be 10 and higher. Float patch from node-gyp to
    accommodate this fact of life.
    
    PR-URL: nodejs#21216
    Refs: nodejs/node-gyp@293092c
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and MylesBorins committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    32f4c18 View commit details
    Browse the repository at this point in the history
  2. build: fix configure script for double-digits

    Compare versions using tuples instead of strings so that it is
    future-proofed against versions that contain a number that is more than
    one digit.
    
    Backport-PR-URL: nodejs#21301
    PR-URL: nodejs#21183
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    mistydemeo authored and MylesBorins committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    56bf7fd View commit details
    Browse the repository at this point in the history
  3. tools: update tooling to work with new macOS CLI …

    Using High Sierra and `xcode-select --install` without installing full
    Xcode, our build tooling breaks due to faulty regular expressions.
    
    Update the `configure` script in our project root directory to handle
    multi-digit version numbers.
    
    `tools/gyp` and `deps/npm/node_modules/node-gyp` still need to be
    updated for a complete fix.
    
    PR-URL: nodejs#21173
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    a5d1ab3 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2018

  1. inspector: don't bind to 0.0.0.0 by default

    Change the bind address from 0.0.0.0 to 127.0.0.1 and start respecting
    the address part of `--inspect=<address>:<port>` so that the bind
    address can be overridden by the user.
    
    Fixes: nodejs#21349
    bnoordhuis committed Jun 17, 2018
    Configuration menu
    Copy the full SHA
    bf5bef5 View commit details
    Browse the repository at this point in the history