Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move test-benchmark-path to sequential #21393

Closed
wants to merge 1 commit into from
Closed

test: move test-benchmark-path to sequential #21393

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 18, 2018

Fixes: #18254

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/92/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 18, 2018
@Trott Trott mentioned this pull request Jun 18, 2018
Closed
@Trott Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jun 18, 2018
@Trott
Copy link
Member Author

Trott commented Jun 18, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15517/

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 19, 2018
@Trott
Copy link
Member Author

Trott commented Jun 19, 2018

👍 here to fast-track.

Trott added a commit to Trott/io.js that referenced this pull request Jun 19, 2018
@Trott
test: move test-benchmark-path to sequential
8944a4f 
Fixes: nodejs#18254

PR-URL: nodejs#21393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@Trott
Copy link
Member Author

Trott commented Jun 19, 2018

Landed in 8944a4f

@Trott Trott closed this Jun 19, 2018
targos pushed a commit that referenced this pull request Jun 20, 2018
@Trott @targos
test: move test-benchmark-path to sequential
f461ae2 
Fixes: #18254

PR-URL: #21393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@targos targos mentioned this pull request Jul 3, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 22, 2018
@Trott @MylesBorins
test: move test-benchmark-path to sequential
64faa71 
Fixes: #18254

PR-URL: #21393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
MylesBorins pushed a commit that referenced this pull request Dec 22, 2018
@Trott @MylesBorins
test: move test-benchmark-path to sequential
e1fbc26 
Fixes: #18254

PR-URL: #21393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@MylesBorins MylesBorins mentioned this pull request Dec 22, 2018
Merged
This was referenced Dec 26, 2018
Closed
Closed
@Trott Trott deleted the test-benchmark-path branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test-benchmark-path
6 participants
@Trott @nodejs-github-bot @cjihrig @hiroppy @gireeshpunathil @trivikr