Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: improve Travis CI settings #21459

Closed
wants to merge 2 commits into from
Closed

build: improve Travis CI settings #21459

wants to merge 2 commits into from

Conversation

TimothyGu
Copy link
Member

@TimothyGu TimothyGu commented Jun 22, 2018 •
edited

Remove macOS-specific steps, and reduce warnings due to compilation with
clang.

Before:

screenshot from 2018-06-22 02-02-54

After:

screenshot from 2018-06-22 02-02-55

Checklist

@TimothyGu
build: improve Travis CI settings
e6809da 
Remove macOS-specific steps, and reduce warnings due to compilation with
clang.
@TimothyGu TimothyGu added the build Issues and PRs related to build files or the CI. label Jun 22, 2018
@TimothyGu TimothyGu requested a review from addaleax June 22, 2018 05:57
@nodejs-github-bot
Copy link
Collaborator

@TimothyGu build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/118/pipeline

@TimothyGu
Copy link
Member Author

Landed in cd8adfa.

@TimothyGu TimothyGu closed this Jun 26, 2018
@TimothyGu TimothyGu deleted the travis branch June 26, 2018 01:56
TimothyGu added a commit that referenced this pull request Jun 26, 2018
@TimothyGu
build: improve Travis CI settings
cd8adfa 
Remove macOS-specific steps, and reduce warnings due to compilation with
clang.

PR-URL: #21459
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jun 26, 2018
@TimothyGu @targos
build: improve Travis CI settings
7d2fe5d 
Remove macOS-specific steps, and reduce warnings due to compilation with
clang.

PR-URL: #21459
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@TimothyGu @MylesBorins
build: improve Travis CI settings
f004b55 
Remove macOS-specific steps, and reduce warnings due to compilation with
clang.

PR-URL: #21459
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@TimothyGu @rvagg
build: improve Travis CI settings
2674336 
Remove macOS-specific steps, and reduce warnings due to compilation with
clang.

PR-URL: #21459
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@TimothyGu @nodejs-github-bot @jasnell @addaleax @lpinca @cjihrig @richardlau @trivikr @MylesBorins