Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix http2stream.pushStream error doc #21487

Merged
merged 1 commit into from Jul 10, 2018

Commits on Jul 10, 2018

  1. doc: fix http2stream.pushStream error doc

    The old error code `ERR_HTTP2_STREAM_CLOSED` was removed in commit
    0babd18 (pull request nodejs#17406), and the
    testcase for http2stream.pushStream was changed accordingly, but the
    documentation change was overlooked.
    
    This commit fixes it and aligns the documentation with the testcase.
    
    This is a part of the fixes hinted by nodejs#21470, which includes some tests
    for error codes usage and documentation and enforces a stricter format.
    
    Refs: nodejs#21470
    Refs: nodejs#17406
    PR-URL: nodejs#21487
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ChALkeR committed Jul 10, 2018
    Copy the full SHA
    094346c View commit details
    Browse the repository at this point in the history