v10.7.0 proposal

.eslintrc.js

@@ -40,6 +40,11 @@ module.exports = {
       ],
       parserOptions: { sourceType: 'module' },
     },
+    {
+      files: ['**/*.md'],
+      parserOptions: { ecmaFeatures: { impliedStrict: true } },
+      rules: { strict: 'off' },
+    },
   ],
   rules: {
     // ESLint built-in rules
@@ -93,6 +98,7 @@ module.exports = {
     'no-dupe-class-members': 'error',
     'no-dupe-keys': 'error',
     'no-duplicate-case': 'error',
+    'no-duplicate-imports': 'error',
     'no-empty-character-class': 'error',
     'no-ex-assign': 'error',
     'no-extra-boolean-cast': 'error',
@@ -241,6 +247,7 @@ module.exports = {
 
     // Custom rules from eslint-plugin-node-core
     'node-core/no-unescaped-regexp-dot': 'error',
+    'node-core/no-duplicate-requires': 'error',
   },
   globals: {
     Atomics: false,

BUILDING.md

@@ -41,14 +41,14 @@ platforms in production.
 |--------------|--------------|----------------------------------|----------------------|------------------|
 | GNU/Linux    | Tier 1       | kernel >= 2.6.32, glibc >= 2.12  | x64, arm             |                  |
 | GNU/Linux    | Tier 1       | kernel >= 3.10, glibc >= 2.17    | arm64                |                  |
-| macOS        | Tier 1       | >= 10.10                         | x64                  |                  |
+| macOS/OS X   | Tier 1       | >= 10.10                         | x64                  |                  |
 | Windows      | Tier 1       | >= Windows 7/2008 R2/2012 R2     | x86, x64             | vs2017           |
 | SmartOS      | Tier 2       | >= 15 < 16.4                     | x86, x64             | see note1        |
 | FreeBSD      | Tier 2       | >= 10                            | x64                  |                  |
 | GNU/Linux    | Tier 2       | kernel >= 3.13.0, glibc >= 2.19  | ppc64le >=power8     |                  |
 | AIX          | Tier 2       | >= 7.1 TL04                      | ppc64be >=power7     |                  |
 | GNU/Linux    | Tier 2       | kernel >= 3.10, glibc >= 2.17    | s390x                |                  |
-| macOS        | Experimental | >= 10.8 < 10.10                  | x64                  | no test coverage |
+| OS X         | Experimental | >= 10.8 < 10.10                  | x64                  | no test coverage |
 | GNU/Linux    | Experimental | kernel >= 2.6.32, glibc >= 2.12  | x86                  | limited CI       |
 | Linux (musl) | Experimental | musl >= 1.0                      | x64                  |                  |
 
@@ -408,7 +408,7 @@ This version of Node.js does not support FIPS.
 It is possible to specify one or more JavaScript text files to be bundled in
 the binary as builtin modules when building Node.js.
 
-### Unix / macOS
+### Unix/macOS
 
 This command will make `/root/myModule.js` available via
 `require('/root/myModule')` and `./myModule2.js` available via

CHANGELOG.md

@@ -8,16 +8,16 @@ release lines.
 
 Select a Node.js version below to view the changelog history:
 
-* [Node.js 10](doc/changelogs/CHANGELOG_V10.md)
-* [Node.js 9](doc/changelogs/CHANGELOG_V9.md)
-* [Node.js 8](doc/changelogs/CHANGELOG_V8.md)
-* [Node.js 7](doc/changelogs/CHANGELOG_V7.md)
-* [Node.js 6](doc/changelogs/CHANGELOG_V6.md)
-* [Node.js 5](doc/changelogs/CHANGELOG_V5.md)
-* [Node.js 4](doc/changelogs/CHANGELOG_V4.md)
-* [io.js](doc/changelogs/CHANGELOG_IOJS.md)
-* [Node.js 0.12](doc/changelogs/CHANGELOG_V012.md)
-* [Node.js 0.10](doc/changelogs/CHANGELOG_V010.md)
+* [Node.js 10](doc/changelogs/CHANGELOG_V10.md) — **Current**
+* [Node.js 9](doc/changelogs/CHANGELOG_V9.md) — End-of-Life
+* [Node.js 8](doc/changelogs/CHANGELOG_V8.md) — **Long Term Support**
+* [Node.js 7](doc/changelogs/CHANGELOG_V7.md) — End-of-Life
+* [Node.js 6](doc/changelogs/CHANGELOG_V6.md) — Long Term Support
+* [Node.js 5](doc/changelogs/CHANGELOG_V5.md) — End-of-Life
+* [Node.js 4](doc/changelogs/CHANGELOG_V4.md) — End-of-Life
+* [io.js](doc/changelogs/CHANGELOG_IOJS.md) — End-of-Life
+* [Node.js 0.12](doc/changelogs/CHANGELOG_V012.md) — End-of-Life
+* [Node.js 0.10](doc/changelogs/CHANGELOG_V010.md) — End-of-Life
 * [Archive](doc/changelogs/CHANGELOG_ARCHIVE.md)
 
 Please use the following table to find the changelog for a specific Node.js
@@ -26,14 +26,13 @@ release.
 <table>
 <tr>
   <th title="Current"><a href="doc/changelogs/CHANGELOG_V10.md">10</a><sup>Current</sup></th>
-  <th><a href="doc/changelogs/CHANGELOG_V9.md">9</a></th>
   <th title="LTS Until 2019-12"><a href="doc/changelogs/CHANGELOG_V8.md">8</a><sup>LTS</sup></th>
   <th title="LTS Until 2019-04"><a href="doc/changelogs/CHANGELOG_V6.md">6</a><sup>LTS</sup></th>
-  <th title="End-of-life since 2018-05-01"><a href="doc/changelogs/CHANGELOG_V4.md">4</a><sup>EOL</sup></th>
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V10.md#10.6.0">10.6.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V10.md#10.7.0">10.7.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V10.md#10.6.0">10.6.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V10.md#10.5.0">10.5.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V10.md#10.4.1">10.4.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V10.md#10.4.0">10.4.0</a><br/>
@@ -44,25 +43,6 @@ release.
 <a href="doc/changelogs/CHANGELOG_V10.md#10.0.0">10.0.0</a><br/>
     </td>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V9.md#9.11.1">9.11.1</a></b><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.11.0">9.11.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.10.1">9.10.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.10.0">9.10.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.9.0">9.9.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.8.0">9.8.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.7.1">9.7.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.7.0">9.7.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.6.1">9.6.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.6.0">9.6.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.5.0">9.5.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.4.0">9.4.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.3.0">9.3.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.2.1">9.2.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.2.0">9.2.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.1.0">9.1.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V9.md#9.0.0">9.0.0</a><br/>
-    </td>
-    <td valign="top">
 <b><a href="doc/changelogs/CHANGELOG_V8.md#8.11.1">8.11.1</a></b><br/>
 <a href="doc/changelogs/CHANGELOG_V8.md#8.11.0">8.11.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V8.md#8.10.0">8.10.0</a><br/>
@@ -126,55 +106,13 @@ release.
 <a href="doc/changelogs/CHANGELOG_V6.md#6.1.0">6.1.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V6.md#6.0.0">6.0.0</a><br/>
   </td>
-  <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V4.md#4.9.1">4.9.1</a></b><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.9.0">4.9.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.8.7">4.8.7</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.8.6">4.8.6</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.8.5">4.8.5</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.8.4">4.8.4</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.8.3">4.8.3</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.8.2">4.8.2</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.8.1">4.8.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.8.0">4.8.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.7.3">4.7.3</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.7.2">4.7.2</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.7.1">4.7.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.7.0">4.7.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.6.1">4.6.2</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.6.1">4.6.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.6.0">4.6.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.5.0">4.5.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.4.7">4.4.7</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.4.6">4.4.6</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.4.5">4.4.5</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.4.4">4.4.4</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.4.3">4.4.3</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.4.2">4.4.2</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.4.1">4.4.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.4.0">4.4.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.3.2">4.3.2</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.3.1">4.3.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.3.0">4.3.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.2.6">4.2.6</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.2.5">4.2.5</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.2.4">4.2.4</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.2.3">4.2.3</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.2.2">4.2.2</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.2.1">4.2.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.2.0">4.2.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.1.2">4.1.2</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.1.1">4.1.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.1.0">4.1.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V4.md#4.0.0">4.0.0</a><br/>
-  </td>
 </tr>
 </table>
 
 ### Notes
 
 * Release streams marked with `LTS` are currently covered by the
-  [Node.js Long Term Support plan](https://github.com/nodejs/LTS).
+  [Node.js Long Term Support plan](https://github.com/nodejs/Release).
 * Release versions displayed in **bold** text represent the most
   recent actively supported release.
 

COLLABORATOR_GUIDE.md

@@ -199,14 +199,10 @@ status indicator.
 
 Do not land any Pull Requests without passing (green or yellow) CI runs. If you
 believe any failed (red or grey) CI sub-tasks are unrelated to the change in the
-Pull Request, you may re-run the sub-task to try to see if it passes (just open
-the failed sub-task page and press the "Rebuild" button; be sure you are still
-logged in for this action). If re-runs of all failed sub-tasks pass (do not
-forget to provide the links for successfully rerun sub-tasks), it is permissible
-to land the Pull Request but only if the initial failures are believed in good
-faith to be unrelated to the changes in the Pull Request. Otherwise, reasonable
-steps must be taken to confirm that the changes are not resulting in an
-unreliable test.
+Pull Request, use "Resume Build" in the left navigation of the relevant
+`node-test-pull-request` job. It will create a new `node-test-pull-request` run
+that preserves all the green results from the current job but re-runs everything
+else.
 
 #### Useful CI Jobs
 

Makefile

@@ -305,6 +305,15 @@ benchmark/napi/function_call/build/Release/binding.node: all \
 		--directory="$(shell pwd)/benchmark/napi/function_call" \
 		--nodedir="$(shell pwd)"
 
+benchmark/napi/function_args/build/Release/binding.node: all \
+		benchmark/napi/function_args/napi_binding.c \
+		benchmark/napi/function_args/binding.cc \
+		benchmark/napi/function_args/binding.gyp
+	$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
+		--python="$(PYTHON)" \
+		--directory="$(shell pwd)/benchmark/napi/function_args" \
+		--nodedir="$(shell pwd)"
+
 # Implicitly depends on $(NODE_EXE).  We don't depend on it explicitly because
 # it always triggers a rebuild due to it being a .PHONY rule.  See the comment
 # near the build-addons rule for more background.
@@ -361,6 +370,7 @@ ADDONS_NAPI_BINDING_GYPS := \
 		$(wildcard test/addons-napi/*/binding.gyp))
 
 ADDONS_NAPI_BINDING_SOURCES := \
+	$(filter-out test/addons-napi/??_*/*.c, $(wildcard test/addons-napi/*/*.c)) \
 	$(filter-out test/addons-napi/??_*/*.cc, $(wildcard test/addons-napi/*/*.cc)) \
 	$(filter-out test/addons-napi/??_*/*.h, $(wildcard test/addons-napi/*/*.h))
 
@@ -613,7 +623,7 @@ doc-only: $(apidoc_dirs) $(apiassets)  ## Builds the docs with the local or the
 	if [ ! -d doc/api/assets ]; then \
 		$(MAKE) tools/doc/node_modules/js-yaml/package.json; \
 	fi;
-	@$(MAKE) $(apidocs_html) $(apidocs_json)
+	@$(MAKE) out/doc/api/all.html out/doc/api/all.json
 
 .PHONY: doc
 doc: $(NODE_EXE) doc-only
@@ -663,10 +673,12 @@ out/doc/api/%.json: doc/api/%.md tools/doc/generate.js tools/doc/json.js
 out/doc/api/%.html: doc/api/%.md tools/doc/generate.js tools/doc/html.js
 	$(call available-node, $(gen-html))
 
-out/doc/api/all.html: $(filter-out out/doc/api/all.html, $(apidocs_html)) \
-	tools/doc/allhtml.js
+out/doc/api/all.html: $(apidocs_html) tools/doc/allhtml.js
 	$(call available-node, tools/doc/allhtml.js)
 
+out/doc/api/all.json: $(apidocs_json) tools/doc/alljson.js
+	$(call available-node, tools/doc/alljson.js)
+
 .PHONY: docopen
 docopen: $(apidocs_html)
 	@$(PYTHON) -mwebbrowser file://$(PWD)/out/doc/api/all.html

README.md

@@ -332,7 +332,7 @@ For more information about the governance of the Node.js project, see
 * [brendanashworth](https://github.com/brendanashworth) -
 **Brendan Ashworth** <brendan.ashworth@me.com>
 * [BridgeAR](https://github.com/BridgeAR) -
-**Ruben Bridgewater** <ruben@bridgewater.de>
+**Ruben Bridgewater** <ruben@bridgewater.de> (he/him)
 * [bzoz](https://github.com/bzoz) -
 **Bartosz Sosnowski** <bartosz@janeasystems.com>
 * [calvinmetcalf](https://github.com/calvinmetcalf) -
@@ -345,6 +345,8 @@ For more information about the governance of the Node.js project, see
 **Colin Ihrig** <cjihrig@gmail.com>
 * [claudiorodriguez](https://github.com/claudiorodriguez) -
 **Claudio Rodriguez** <cjrodr@yahoo.com>
+* [codebytere](https://github.com/codebytere) -
+**Shelley Vohr** <codebytere@gmail.com> (she/her)
 * [danbev](https://github.com/danbev) -
 **Daniel Bevenius** <daniel.bevenius@gmail.com>
 * [DavidCai1993](https://github.com/DavidCai1993) -
@@ -420,7 +422,7 @@ For more information about the governance of the Node.js project, see
 * [kunalspathak](https://github.com/kunalspathak) -
 **Kunal Pathak** <kunal.pathak@microsoft.com>
 * [lance](https://github.com/lance) -
-**Lance Ball** <lball@redhat.com>
+**Lance Ball** <lball@redhat.com> (he/him)
 * [Leko](https://github.com/Leko) -
 **Shingo Inoue** <leko.noor@gmail.com> (he/him)
 * [lpinca](https://github.com/lpinca) -

benchmark/napi/function_args/.gitignore

@@ -0,0 +1 @@
+build/