v10.8.0 proposal #22040
Merged
v10.8.0 proposal #22040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents AssertionError from reporting string literal, instead displays values of first 2 args passed to assert.strictEqual() PR-URL: #21828 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: #8913 PR-URL: #21755 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ProcessEmitWarning will already format the message, there is no need to call snprintf here. PR-URL: #21832 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #21750 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #21753 Refs: #8913 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Now that TracedValue has landed, add more detailed process `__metadata` including versions, arch, platform, release detail, and argv/execArgv to the trace event log. PR-URL: #21785 Reviewed-By: Anna Henningsen <anna@addaleax.net>
`require('worker_threads')` is not an instance of `EventEmitter`. So
`on` method would not be in it. The correct way to receive the message
would be to attach a listener to the `message` event on the
`parentPort`.
PR-URL: #21486
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #20954 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #21862 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #21858 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #21831 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
When there are three arguments in strictEqual() call and AssertionError exists, the previous two values are not printed. This improves debugging messages visibility when there is a fail. The messages were removed where the instruction is self-explanatory. PR-URL: #21833 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This is done in preparation for landing https://chromium-review.googlesource.com/c/v8/v8/+/1126099 on the V8 side, which extends the existing PromiseRejectEvent mechanism with new hooks for reject/resolve after a Promise was previously resolved already. Refs: nodejs/promises-debugging#8 Design: https://goo.gl/2stLUY PR-URL: #21838 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Original commit message:
[turbofan] Remove optimization of default Promise capability functions.
The JSCallReducer could in theory inline the default resolve and reject
functions passed to the executor in the Promise constructor. But that
inlining is almost never triggered because we don't have SFI based feedback
in the CallIC. Also the use of the Promise constructor is discouraged,
so we shouldn't really need to squeeze the last bit of performance out
of this even in the future.
Getting rid of this optimization will make significantly easier to
implement the Swallowed Rejection Hook, as there's less churn on the
TurboFan side then.
Bug: v8:7919
Change-Id: If0c54f1c6c7ce95686cd74232be6b8693ac688c9
Reviewed-on: https://chromium-review.googlesource.com/1125926
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54210}
Refs: v8/v8@2075910
PR-URL: #21838
Refs: nodejs/promises-debugging#8
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Original commit message:
[promise] Implement Swallowed Rejection Hook.
This extends the current Promise Rejection Hook with two new events
kPromiseRejectAfterResolved
kPromiseResolveAfterResolved
which are used to detect (and signal) misuse of the Promise constructor.
Specifically the common bug like
new Promise((res, rej) => {
res(1);
throw new Error("something")
});
where the error is silently swallowed by the Promise constructor without
the user ever noticing can be caught via this hook.
Doc: https://goo.gl/2stLUY
Bug: v8:7919
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I890a7e766cdd1be88db94844fb744f72823dba33
Reviewed-on: https://chromium-review.googlesource.com/1126099
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54309}
Refs: v8/v8@907d7bc
PR-URL: #21838
Refs: nodejs/promises-debugging#8
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
It was breaking during install when .gypi strings had quotes in them. e.g.: 'foo': 'bar="baz"'
A small refactor – this removes one layer of pointer indirection. (The performance gain is likely negligible, the main point here being that this encapsulates libuv request management a bit more.) PR-URL: #21839 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jon Moss <me@jonathanmoss.me>
PR-URL: #21872 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Remove a list of HTTP2 errors as well as `nghttp2_errname()` that converted an integer nghttp2 error code to a string representation. We already use `nghttp2_strerror()` for this, which is provided by nghttp2 returns a better error string anyway. PR-URL: #21827 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Recent events (involving a maliciously published version of a popular module's dependency) have reinvigorated my interest in seeing us move to `npm ci` instead of `npm install`. This moves us to `npm ci` where possible in Makefile and vcbuild.bat. PR-URL: #21802 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Adding new build targets: 'bench-addons' & 'bench-addons-clean'. With these two, it will be easier to manage the dependencies among targets and easier to build/clean the addons which are being used in benchmarking. PR-URL: #20905 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #21901 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
* Pin version numbers when using `npx`. This means we can be careful about updating what we run. (Thinking about the recent eslint-scope thing.) * Add removeNPMAbsolutePaths to get rid of unused fields in package.json files. These unused fields can cause unnecessary churn, as at least one contains an absolute path that will be different for each developer. PR-URL: #21819 Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Refactor test-cluster-net-listen-relative-path: * Use arrow funcitons for callbacks. * Move skip-test code closer to start of file. * Use assert.ok() where appropriate. * Capitalize and punctuate comments. PR-URL: #21863 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #21908 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #21868 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #21490 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2 tasks
Removes a couple of unused/empty functions inside of `tools/test.py` PR-URL: #22010 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
At the last TC39 meeting, a new type of Module Records backed by JavaScript source called Dynamic Module Records was discussed, and it is now at Stage 1. Regardless of whether that proposal makes it all the way into the spec, SourceTextModule is indeed a more descriptive and accurate name for what this class represents. PR-URL: #22007 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Improve assertions in test-child-process-execsync by removing unneeded third arguments and replacing equal checks with assert.ok() where appropriate. PR-URL: #22016 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
force-pushed
the
v10.8.0-proposal
branch
from
843cb58
to
6949c65
Compare
|
@devsnek it's not too late. I've included it and a few others that landed yesterday. |
|
For the changelog |
targos
force-pushed
the
v10.8.0-proposal
branch
from
6949c65
to
d3606ea
Compare
|
@refack thanks. I fixed it. |
@targos CI is actually ready as of yesterday https://nodejs.org/download/nightly/v11.0.0-nightly20180731be322bd9ad/ (Today's fail was #22006, workaround implemented) |
|
@refack It's not ready for v10 AFAICT, only v11. |
|
Let's see |
Ohh right, it was my objection to nodejs/build#1409 (comment), but after testing the generated binaries are backwards compatible, so we can move forward with this. Should be ready for the next version. |
This reverts a commit that accidentally introduced a semver-major change to Node 10 and broke userland code. A subsequent fix to that change and documentation change are reverted with it. Revert "http: fix res emit close before user finish" This reverts commit 2a9c833. Revert "http: always emit close on req and res" This reverts commit 8029a24. Revert "doc: fix HTTP req/res 'close' description" This reverts commit 8ab7ea6. PR-URL: #21809 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Notable changes: * deps: * Upgrade npm to 6.2.0. (#21592) * npm has moved. This release updates various URLs to point to the right places for bugs, support, and PRs. * Fix the regular expression matching in `xcode_emulation` in `node-gyp` to also handle version numbers with multiple-digit major versions which would otherwise break under use of XCode 10. * The npm tree has been *significantly* flattened. Tarball size for the npm package has gone from 8MB to 4.8MB. * Changelogs: https://github.com/npm/npm/releases/tag/v6.2.0-next.0 https://github.com/npm/npm/releases/tag/v6.2.0-next.1 https://github.com/npm/cli/releases/tag/v6.2.0) PR-URL: #22040
targos
force-pushed
the
v10.8.0-proposal
branch
from
d3606ea
to
89f483b
Compare
|
Release build done @ https://ci-release.nodejs.org/job/iojs+release/3623/ I'm going to test and promote in ~1 hour |
targos
added a commit
that referenced
this pull request
Aug 1, 2018
Notable changes: * deps: * Upgrade npm to 6.2.0. (#21592) * npm has moved. This release updates various URLs to point to the right places for bugs, support, and PRs. * Fix the regular expression matching in `xcode_emulation` in `node-gyp` to also handle version numbers with multiple-digit major versions which would otherwise break under use of XCode 10. * The npm tree has been *significantly* flattened. Tarball size for the npm package has gone from 8MB to 4.8MB. * Changelogs: https://github.com/npm/npm/releases/tag/v6.2.0-next.0 https://github.com/npm/npm/releases/tag/v6.2.0-next.1 https://github.com/npm/cli/releases/tag/v6.2.0) PR-URL: #22040
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Aug 1, 2018
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-08-01, Version 10.8.0 (Current), @targos
Notable Changes
places for bugs, support, and PRs.
xcode_emulationinnode-gyptoalso handle version numbers with multiple-digit major versions which would
otherwise break under use of XCode 10.
package has gone from 8MB to 4.8MB.
6.2.0-next.0,
6.2.0-next.1,
6.2.0.
Commits
335575e49b] - benchmark: remove arrays benchmark (Peter Marshall) #2183162024b651e] - build: create V8 code cache after script is run (Joyee Cheung) #2156750ccda2a00] - build: increase macOS minimum supported version (Michaël Zasso) #218835e1ceaabaa] - build: remove redundant Makefile target (Rich Trott) #219154f00562ef0] - build: add new benchmark targets (Kenny Yuan) #209054c5fc5c7ce] - build: move tonpm ciwhere possible (Rich Trott) #21802e0f3d5703a] - build,win,v8: allow precompiling objects-inl.h (João Reis) #2177287ed6e6351] - (SEMVER-MINOR) deps: upgrade npm to 6.2.0 (Kat Marchán) #21592f868415cf6] - deps: cherry-pick 804a693 from upstream V8 (Matheus Marchini) #21855b56c8ad879] - deps: V8: Backport of 0dd3390 from upstream (James M Snell) #21899ec0ff7008a] - deps: cherry-pick 907d7bc from upstream V8 (Michaël Zasso) #21838c23e8b51ea] - deps: cherry-pick 2075910 from upstream V8 (Michaël Zasso) #2183840fedd3620] - dgram: add getters/setters for private APIs (cjihrig) #2192398ef8cfb8e] - dgram: make _createSocketHandle() internal only (cjihrig) #21923ae17d18013] - dgram: hide underscored Socket properties (cjihrig) #21923b5b74382e0] - dgram: hide _healthCheck() and _stopReceiving() (cjihrig) #21923b5ae33959b] - doc: add pronouns to readme (Teddy Katz) #22036f4b6031e39] - doc: clarify text about internal module changes (MaleDong) #220241f9570bd10] - doc: add missing worker error (Benjamin Gruenbaum) #2194767d7a15886] - doc: fix typo in releases.md (Vitor Bruno de Oliveira Barth) #219902a0fa4792e] - doc: do not advise to cancel full CI on onboarding (Vse Mozhet Byt) #21977478dbee8fe] - doc: replace deprecated CI job (Vse Mozhet Byt) #219385b0c451e61] - doc: add guide for updating N-API API surface (Hitesh Kanwathirtha) #2187796bb6052e9] - doc: add node-test-commit-custom-suites to docs (Rich Trott) #21927c44df51249] - doc: link n-api module init to multi-load addons (Gabriel Schulhof) #21891c3d9000111] - doc: document http2 network error behaviour (Anna Henningsen) #21861e8d5787840] - doc: document MODULE_NOT_FOUND error (Jacob Page) #218945e562fd792] - doc: fix sorting in thevm.Modulesection (Vse Mozhet Byt) #21931eabe907e03] - doc: fix descriptions of sync methods in fs.md (Tim Ruffles) #21747bd352f0298] - doc: update and improve the release guide (Michaël Zasso) #21868fd5a0c7a1f] - doc: fix incorrect method name (Anto Aravinth) #21908af1530e06d] - doc: add cjihrig pronouns (cjihrig) #219014d78a21d8c] - doc: add missingrequireto example in http2.md (Kevin Simper) #21858ab0da57150] - doc: make minor improvements to collab guide (Rich Trott) #21862b510cdc756] - doc: fix worker example to receive message (Sakthipriyan Vairamani (thefourtheye)) #21486d91742aa9a] - fs: reduce memory retention when streaming small files (Anna Henningsen) #21968484140e223] - fs: stop lazy loading stream constructors (Michaël Zasso) #217768799f43fb0] - http: revert "http: always emit close on req and res" (Michaël Zasso) #21809a5928712c9] - http: name anonymous function in _http_common.js (Petras) #21755337b2df82f] - http2: release request()'s "connect" event listener after it runs (James Ide) #219161e15581823] - http2: remove unused nghttp2 error list (Anna Henningsen) #21827baf3027c77] - lib: remove usc-2 encoding (Brian White) #219649817e405ee] - (SEMVER-MINOR) lib,src: replace all C++ promises with JS promises (Ruben Bridgewater) #2083045816c50ac] - n-api: guard against cond null dereference (Gabriel Schulhof) #218712548f75a92] - src: use UTF-8 for naming interfaces in unix (Ujjwal Sharma) #219266b6a26bb8d] - src: use kInternalized instead of kNormal (Ujjwal Sharma) #219262c95b96e8e] - src: remove calls to deprecated v8 functions (NewFromUtf8) (Ujjwal Sharma) #21926e0336b2891] - src: fix may be uninitialized warning in n-api (Michael Dawson) #218982f3a28dbf2] - src: use available ReqWrap instance for libuv req (Jon Moss) #2198080b5c914bb] - src: add proper MemoryInfoName to wrappers (Joyee Cheung) #21939f6606bf9e4] - src: add missing cmath include to traced_value.cc (Anna Henningsen) #21924be75795868] - src: don't store one-use strings in variable (Jon Moss) #21876d9cd171a6b] - src: remove unnecessary else (Jon Moss) #218744f8620e2b7] - src: fix formatting of PIDs (Tobias Nießen) #21852d0f8af021f] - src: use offset calc. instead ofreq-\>datain node_file (Anna Henningsen) #2183941ff1bb9c7] - src: prepare for V8 Swallowed Rejection Hook (Benedikt Meurer) #21838c45623a548] - src: avoid unnecessarily formatting a warning (Tobias Nießen) #218326af4f1f515] - stream: name anonymous function in _stream_writable.js (mariotsi) #21753d0c16f4b2a] - stream: named anonymous functions in _stream_readable.js (Simionescu, Radu) #217503d05d82353] - test: improve assertions in child-process-execsync (bhavayAnand9) #2201662fd84528e] - test: improve inspect readability (Ruben Bridgewater) #21624fe1823dc21] - test: remove custom AsyncHooksTestConfiguration (Jon Moss) #220084510ca349e] - test: add tests for fs/promises chown functions (shisama) #2057461ae592c4f] - test: remove setTimeout in test-net-connect-unref (conectado) #219694958501ac0] - test: remove timeout from test-pipe-stream (Anna Henningsen) #21837af6b82469d] - test: fix unreliable test-fs-stat-bigint (sagulati) #21949793a5bb4af] - test: don't fail http2 abort test if 'data' is called multiple times (Sam Ruby) #21925623ef4961b] - test: address flaky worker test (Rich Trott) #218933213c09e3a] - test: provide better message for orphan output documentation (Sam Ruby) #21913eea199bf98] - test: fix http2 connection abort test (Anna Henningsen) #21861bea1ee8e8e] - test: make crashOnUnhandleRejection opt-out (Michaël Zasso) #2184981915632e4] - test: allow tests to pass without internet (Helio Frota) #2190946d14fc0e8] - test: refactor cluster-net-listen-relative-path (Rich Trott) #21863756dff498a] - test: refactor test-module-loading assertions (Bruno Pinho) #21833292aa42bd1] - test: fix faulty relpath test (Gus Caplan) #20954a086604f8f] - test: remove 3rd arg from to assert.strictEqual() (hectorcoronado) #21828580071dde4] - tls: named anonymous functions in _tls_wrap.js (prayag21) #217560f70017f35] - tls: name anonymous function in tls.js (Kevin Lacabane) #217540151486b9d] - tools: patch gyp to avoid xcrun errors (Ujjwal Sharma) #21520b520216518] - tools: update cpplint to check for inline headers (Ujjwal Sharma) #2152198d461e8cc] - tools: update ESLint to 5.2.0 (Yuta Hiroto) #21817ce527d973a] - tools: define xrange() in Python 3 (cclauss) #21945254aa83174] - tools: remove obsolete entries from license (Rich Trott) #2197936f8b82697] - tools: flatten apidoc headers (Sam Ruby) #219365e71d63bfe] - tools: validate apidoc links (Sam Ruby) #21889b98bf829d0] - tools: build API TOC using raw headers (Sam Ruby) #219225606f0b1f2] - tools: create HTML docs with unified/remark/rehype (Sam Ruby) #21490f89d194deb] - tools: improve update-eslint.sh (Rich Trott) #218196b925ebaba] - tools: make getnodeversion.py python3-compatible (silverwind) #21872ff5c6dcd1b] - tools: properly convert .gypi in install.py (Michael Achenbach) #2185002e665c712] - tools,test: remove unused config hooks (Jon Moss) #22010cfeed2b193] - trace_events: add support for builtin trace (James M Snell) #21899d7edee4954] - trace_events: add more process metadata (James M Snell) #217859a88fe4d5e] - vm: rename vm.Module to vm.SourceTextModule (Gus Caplan) #22007