n-api: clean up thread-safe function #22259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Aug 22, 2018
src/node_api.cc
Outdated
| @@ -827,6 +827,339 @@ napi_status ConcludeDeferred(napi_env env, | |||
| return GET_RETURN_STATUS(env); | |||
| } | |||
|
|
|||
| class TsFn: public node::AsyncResource { | |||
There was a problem hiding this comment.
style nits: I'd very much prefer to spell out ThreadSafeFunction, and we use spaces before the : in a class declaration
If you need abbreviations for individual functions, I think an using line might do the trick
There was a problem hiding this comment.
Yes, please avoid abbreviations
src/node_api.cc
Outdated
|
|
||
| node::Environment::GetCurrent(env->isolate)->CloseHandle( | ||
| reinterpret_cast<uv_handle_t*>(&async), | ||
| [] (uv_handle_t* handle) -> void { |
There was a problem hiding this comment.
style nit: No space after []
Aside, we have make format-cpp (possibly preceded by make format-cpp-build), that should take care of style issues now :)
kfarnung
approved these changes
Aug 23, 2018
gabrielschulhof
force-pushed
the
cleanup-tsfn
branch
from
d18e135
to
dc67065
Compare
|
Another CI from the top: https://ci.nodejs.org/job/node-test-pull-request/16731/ |
4 tasks
* Move class `TsFn` to name space `v8impl` and rename it to `ThreadSafeFunction` * Remove `NAPI_EXTERN` from API declarations, because it's only needed in the header file.
gabrielschulhof
force-pushed
the
cleanup-tsfn
branch
from
dc67065
to
2790896
Compare
|
Wow! |
|
Resumed as CI: https://ci.nodejs.org/job/node-test-pull-request/16915/ ✓ |
|
Landed in 403df7c. |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Aug 31, 2018
* Move class `TsFn` to name space `v8impl` and rename it to `ThreadSafeFunction` * Remove `NAPI_EXTERN` from API declarations, because it's only needed in the header file. PR-URL: nodejs#22259 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Sep 1, 2018
* Move class `TsFn` to name space `v8impl` and rename it to `ThreadSafeFunction` * Remove `NAPI_EXTERN` from API declarations, because it's only needed in the header file. PR-URL: #22259 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
* Move class `TsFn` to name space `v8impl` and rename it to `ThreadSafeFunction` * Remove `NAPI_EXTERN` from API declarations, because it's only needed in the header file. PR-URL: #22259 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
* Move class `TsFn` to name space `v8impl` and rename it to `ThreadSafeFunction` * Remove `NAPI_EXTERN` from API declarations, because it's only needed in the header file. PR-URL: #22259 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced Sep 6, 2018
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Dec 28, 2018
* Move class `TsFn` to name space `v8impl` and rename it to `ThreadSafeFunction` * Remove `NAPI_EXTERN` from API declarations, because it's only needed in the header file. PR-URL: nodejs#22259 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 18, 2019
* Move class `TsFn` to name space `v8impl` and rename it to `ThreadSafeFunction` * Remove `NAPI_EXTERN` from API declarations, because it's only needed in the header file. Backport-PR-URL: #25002 PR-URL: #22259 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
* Move class `TsFn` to name space `v8impl` and rename it to `ThreadSafeFunction` * Remove `NAPI_EXTERN` from API declarations, because it's only needed in the header file. Backport-PR-URL: #25002 PR-URL: #22259 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TsFnto name spacev8implNAPI_EXTERNfrom API declarations, because it's only neededin the header file.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes