Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,tools: tweak the travis config #22417

Merged
merged 0 commits into from Aug 23, 2018
Merged

build,tools: tweak the travis config #22417

merged 0 commits into from Aug 23, 2018

Conversation

refack
Copy link
Contributor

@refack refack commented Aug 20, 2018

  • Give the two matrix configuration names
  • Switch from test-ci to test for less noise (atcualy making the log fit into Travis' limits)
  • A touch of refactoring env definition

Before:

6473 /usr/bin/python2.7 tools/test.py -j 2 -p tap --logfile test.tap \
6474		--mode=release --flaky-tests=run \
6475		 default addons addons-napi doctool
6476 TAP version 13
6477 1..2369
...
10000   duration_ms: 0.171
---
This log is too long to be displayed. Please reduce the verbosity of your build or download the raw log.

After:

4594 make[2]: Leaving directory `/home/travis/build/refack/node/test/addons/zlib-binding/build'
4595 [07:47|% 100|+ 2366|-   0]: Done
4596 The command "make -j2 test" exited with 0.
4598 store build cache
4606 changes detected, packing new archive
.
uploading archive
Done. Your build exited with 0.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@refack refack added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. meta Issues and PRs related to the general management of the project. labels Aug 20, 2018
@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/602/pipeline

@refack
Copy link
Contributor Author

refack commented Aug 20, 2018

/CC @nodejs/build @nodejs/build-infra

richardlau
richardlau approved these changes Aug 20, 2018
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, there was a suggestion in #21263 to use lint for the linter rather than lint-ci.

addaleax
addaleax approved these changes Aug 20, 2018
View reviewed changes
.travis.yml Outdated
matrix:
include:
- os: linux
- name: "Linter"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's new https://changelog.travis-ci.com/announcing-build-stages-ga-job-names-and-conditions-v1-as-platform-default-66397

refack added a commit to refack/node that referenced this pull request Aug 23, 2018
@refack
build,tools: tweak the travis config
c0ff4a4 
PR-URL: nodejs#22417
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack
Copy link
Contributor Author

refack commented Aug 23, 2018 •
edited

Since this is a Travis tweak CI test should be the travis run 82700662 82706186.
Also running sanity with lite CI 642 647 649

@refack
Copy link
Contributor Author

refack commented Aug 23, 2018 •
edited

landed in c0ff4a4 9acf4c5

@refack refack merged commit 9acf4c5 into nodejs:master Aug 23, 2018
@refack refack deleted the tweak-travis branch August 23, 2018 16:17
@devsnek
Copy link
Member

devsnek commented Aug 24, 2018

@refack (carried from irc)

this improves ui but not raw logs (example: https://api.travis-ci.com/v3/job/141748013/log.txt)

there might be other items we can omit from the log unless there is a failure (ex. gcc output)

targos pushed a commit that referenced this pull request Aug 24, 2018
@refack @targos
build,tools: tweak the travis config
d00c745 
PR-URL: #22417
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@richardlau richardlau mentioned this pull request Aug 25, 2018
Closed
@refack
Copy link
Contributor Author

refack commented Aug 25, 2018

Another issue: make test fails after make lint (in case there is lint) and doesn't run the test suite.

targos pushed a commit that referenced this pull request Sep 3, 2018
@refack @targos
build,tools: tweak the travis config
3915537 
PR-URL: #22417
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Sep 5, 2018
Merged
@beevelop beevelop mentioned this pull request Sep 6, 2018
Closed
@beevelop beevelop mentioned this pull request Sep 6, 2018
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@refack @MylesBorins
build,tools: tweak the travis config
714c1c6 
PR-URL: #22417
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@refack @rvagg
build,tools: tweak the travis config
313ef6f 
PR-URL: #22417
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@mmarchini mmarchini mmarchini approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gibfahn gibfahn gibfahn approved these changes

@gdams gdams gdams approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet