Commits on Oct 23, 2018

1. deps: backport a8f6869 from upstream V8 …

   The upstream V8 commit a8f68691 was originally cherry-picked onto
   nodejs/node master as commit bb35752, then backported to v10.x-staging
   and released in Node.js v10.10.0 as 5e9ed6d. This commit cherry-picks
   that commit back to the v8.x-staging branch.
   
   Refs: v8/v8@a8f6869
   Refs: nodejs#22122
   Refs: nodejs@bb35752
   Refs: nodejs@5e9ed6d
   
   Original commit message:
   
     [debug] Fully implement Debug::ArchiveDebug and Debug::RestoreDebug.
   
     I have a project that embeds V8 and uses a single `Isolate` from multiple
     threads. The program runs just fine, but sometimes the inspector doesn't
     stop on the correct line after stepping over a statement that switches
     threads behind the scenes, even though the original thread is restored by
     the time the next statement is executed.
   
     After some digging, I discovered that the `Debug::ArchiveDebug` and
     `Debug::RestoreDebug` methods, which should be responsible for
     saving/restoring this `ThreadLocal` information when switching threads,
     currently don't do anything.
   
     This commit implements those methods using MemCopy, in the style of other
     Archive/Restore methods in the V8 codebase.
   
     Related: https://groups.google.com/forum/#!topic/v8-users/_Qf2rwljRk8
   
     R=yangguo@chromium.org,jgruber@chromium.org
     CC=info@bnoordhuis.nl
   
     Bug: v8:7230
     Change-Id: Id517c873eb81cd53f7216c7efd441b956cf7f943
     Reviewed-on: https://chromium-review.googlesource.com/833260
     Commit-Queue: Yang Guo <yangguo@chromium.org>
     Reviewed-by: Yang Guo <yangguo@chromium.org>
     Cr-Commit-Position: refs/heads/master@{#54902}
   
   PR-URL: nodejs#22714
   
   ADDITIONAL CHANGES:
   
   Support optional boolean argument to DisableBreak constructor.
   
   This allows a stack-allocated DisableBreak object to re-enable breakpoints
   temporarily, rather than always disabling them.
   
   This functionality anticipates an upstream change that will be introduced
   in V8 6.7.176: v8/v8@cc9736a
   
   More immediately, these changes should fix a cctest compile error in this
   backport PR: nodejs#22714 (comment)

   

   benjamn committed Oct 23, 2018
   Copy the full SHA

   d9f4465 View commit details

   Browse the repository at this point in the history