Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v10.10.0 #22716

Merged
merged 208 commits into from Sep 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
208 commits
Select commit Hold shift + click to select a range
5cfab14
test: remove common.hasTracing
Trott Aug 10, 2018
4a28d38
test: mark async-hooks/test-statwatcher as flaky
joyeecheung Aug 15, 2018
2ed22df
test: mark async-hooks/test-callback-error as flaky
joyeecheung Aug 15, 2018
cdf6471
util: fix sparse array inspection
BridgeAR Aug 12, 2018
4d4180b
util,assert: improve comparison performance
BridgeAR Aug 10, 2018
3f93782
lib: remove unused exec param
Aug 12, 2018
d3ceaa1
http2: emit timeout on compat request and response
jasnell Aug 10, 2018
7972298
doc: clarify ServerResponse explanations
Aug 14, 2018
dec42b5
cli: fix flags on help output
devsnek Aug 11, 2018
44bcc1d
test: fix cctest URLTest.ToFilePath on Win32 without Intl
jasnell Aug 11, 2018
c894145
doc: Windows building supported on x64
refack Aug 16, 2018
866965e
src: fix race on modpending
rpetrich Jun 30, 2018
9142935
doc: clarify that new URL().port could be an empty string
mcollina Aug 10, 2018
eab377f
deps: fix CRLF in text file not present in upstream
joyeecheung Aug 15, 2018
4638ce6
src: perform integrity checks on built-in code cache
joyeecheung Aug 6, 2018
e644088
doc: add doc for --loader option
SirR4T Aug 3, 2018
d86e615
doc: clarify documentation of pipes and zlib objects
andreasg123 Aug 16, 2018
c207865
src: encode 0x27 (') for special URLs
TimothyGu Jul 30, 2018
725a2b1
tools: simplify ESLint invocation in Makefile
Trott Aug 16, 2018
ad97314
fs: readdir optionally returning type information
bengl Jul 28, 2018
459d676
util: harden util.inspect
BridgeAR Jul 18, 2018
e9ac683
util: properly indent special properties
BridgeAR Aug 12, 2018
acfb724
test: remove harmony flags
BridgeAR Aug 12, 2018
3dc3a31
util: improve empty typed array inspection
BridgeAR Aug 12, 2018
f763ac7
util: escape symbol and non-enumerable keys
BridgeAR Aug 13, 2018
1828017
util: mark special entries as such
BridgeAR Aug 12, 2018
1ebaa2a
doc: unify optional arguments format in headings
vsemozhetbyt Aug 19, 2018
c17e980
doc: clarify fs.write[Sync]() descriptions
vsemozhetbyt Aug 19, 2018
2b1cb3b
util,assert: improve performance
BridgeAR Aug 6, 2018
149c209
test: harden test-gc-http-client
BridgeAR Aug 17, 2018
ed874e4
build: use echo command instead of shell comments
danbev Aug 13, 2018
fd6033c
build: add test-doc to test target
danbev Aug 13, 2018
90e99da
deps: upgrade to libuv 1.23.0
cjihrig Aug 17, 2018
8f760c2
build: touch tools/doc/node_modules after run
danbev Aug 16, 2018
3b44053
os: improve networkInterfaces performance
BridgeAR Aug 16, 2018
30b22a6
os: destructure ERR_SYSTEM_ERROR properly
cjihrig Aug 19, 2018
fbc189b
test: cover error case in os getCheckedFunction()
cjihrig Aug 20, 2018
660c515
build: move available-node variable to top
danbev Aug 16, 2018
33994d8
test: remove third argument from assert.strictEqual()
diprudnikov Aug 17, 2018
5aa3100
test: fix flaky http timeout test
Trott Aug 19, 2018
22adebf
test: move http timeout test to parallel
Trott Aug 19, 2018
e8e014a
test: improve assert message in http timeout test
Trott Aug 19, 2018
f86ca89
util: Fix number format for `pad`
Jul 20, 2018
611f423
deps: patch V8 to 6.8.275.30
targos Aug 4, 2018
282a45d
doc: update wrapping-related documentation
Aug 21, 2018
107c8c0
perf_hooks: move strings to env
jasnell Aug 19, 2018
53fb7af
stream: restore flow if there are 'data' handlers after once('readable')
mcollina Aug 9, 2018
c07a065
http: adding doc and debug for calling empty string on write function
antsmartian Aug 21, 2018
38b0c1f
test: remove redundant cli tests
bengl Aug 16, 2018
acfb29c
test: harden sequential/test-performance
BridgeAR Aug 19, 2018
0b340ab
repl: tab auto complete big arrays
BridgeAR Aug 20, 2018
fc1259b
build: use `npm ci`
refack Aug 18, 2018
f27a254
doc: make createPushResponse() more detailled
Aug 17, 2018
e2a801a
async_hooks: adding regression test case for async/await
antsmartian Aug 22, 2018
2a849ba
doc: state callback behavior on empty buffer
RubenVerborgh Aug 22, 2018
3915537
build,tools: tweak the travis config
refack Aug 20, 2018
6228433
doc: add lundibundi to collaborators
lundibundi Aug 23, 2018
887c43f
worker: remove redundant function call to `setupPortReferencing`
oyyd Aug 20, 2018
efe71e9
build: Don't set `-fno-threadsafe-statics` on macOS
kylef Aug 8, 2018
e684382
test: remove isGlibc from common
jasnell Aug 21, 2018
98af170
test: move common.ArrayStream to separate module
jasnell Aug 21, 2018
9d246f9
tools: update ESLint to 5.4.0
Trott Aug 22, 2018
e254130
doc: tweak macOS-firewall note position
ZYSzys Aug 21, 2018
7794d4e
test,stream: fix pipeline test so it runs well on Windows in older nodes
mcollina Aug 22, 2018
ae016c8
test: add tests for dnsPromises.lookup
Jun 27, 2018
fcf059a
test: add test unknown credential error of process.setgroups
Aug 16, 2018
5b14066
util: restore all information in inspect
BridgeAR Aug 21, 2018
219da67
os: add os.{get,set}Priority()
cjihrig Aug 19, 2018
f0153d0
lib: extract validateNumber validator
maclover7 Aug 3, 2018
07ceb54
test: move hijackstdio out of require('common')
jasnell Aug 22, 2018
c04f1f3
test: flaky everywhere test-trace-events-fs-sync
refack Aug 23, 2018
c9c8b29
test: move common.onGC to individual module
jasnell Aug 21, 2018
594b237
test: add v8 benchmark test
lundibundi Aug 15, 2018
caaac3f
test: add vm benchmark test
lundibundi Aug 15, 2018
c91472e
test: add streams benchmark test
lundibundi Aug 15, 2018
a704ed8
test: improve code coverage for string decoder
BeniCheni Aug 14, 2018
803b324
test: move common.isCPPSymbolsNotMapped to tick-processor tests
jasnell Aug 22, 2018
e09296b
test: remove third argument from strictEqual()
neeraj-laad Aug 21, 2018
cd5c672
gyp: muffle xcodebuild warnings
ryzokuken Jul 27, 2018
de1d8e8
test: move custom WHATWG URL tests into separate files
joyeecheung Aug 21, 2018
2e0652d
tools: add missing package-lock to clang-format
targos Aug 24, 2018
060a62f
doc: support 'removed' field in doc YAML sections
SirR4T Aug 7, 2018
10b7404
doc: document removed error codes
SirR4T Aug 2, 2018
ae34e83
doc: clarify git config name/email requirements
addaleax Aug 21, 2018
2ee0ef1
doc: add GitHub email set up link to COLLABORATOR_GUIDE
lundibundi Aug 25, 2018
6405ad9
deps: import acorn@5.7.2
rubys Aug 23, 2018
4dcf418
doc: clarify ERR_AMBIGUOUS_ARGUMENT
Trott Aug 27, 2018
f78e908
doc: simplify http2 wording and formatting
Trott Aug 26, 2018
6698354
http2: throw better error when accessing unbound socket proxy
jasnell Aug 23, 2018
9ac6530
test: remove string literal from strictEqual()
ScottyVG Aug 24, 2018
0ffedd2
test: add test for internalConnect() when address type is IPv6
yanivfriedensohn Aug 21, 2018
4d802f0
src: implement v8::Platform::CallDelayedOnWorkerThread
alexkozy Aug 18, 2018
727187d
src: yield empty maybes for failed AsyncWrap::MakeCallback calls
addaleax Aug 1, 2018
cae21ea
lib,src: standardize `owner_symbol` for handles
addaleax Jul 27, 2018
778ddc7
process: use owner_symbol for `_getActive*`
addaleax Jul 27, 2018
52c797c
src: refactor options parsing
addaleax Aug 10, 2018
5f392a1
src: move more to node_process.cc from node.cc
jasnell Aug 20, 2018
e5d47c4
src: fix --without-ssl build
ianloic Aug 23, 2018
b58ac09
process: add allowedNodeEnvironmentFlags property
boneskull Mar 13, 2018
2a3e26a
http2: graduate from experimental
jasnell Aug 23, 2018
7282768
src: fix NODE_OPTIONS parsing bug
addaleax Aug 26, 2018
58708ee
doc: initial cut at support tiers for diag tools
mhdawson Jul 18, 2018
8eae030
n-api: remove idle_running from TsFn
ralphtheninja Jul 27, 2018
8ec5a07
doc: warn against streaming from character devices
gireeshpunathil Jun 8, 2018
8d02fc6
src: add missing `NODE_WANT_INTERNALS` guards
addaleax Aug 24, 2018
2d8e637
test: properly extend process.env in child_process
legendecas Aug 21, 2018
b30b5de
src,deps: add isolate parameter to String::Concat
targos Aug 24, 2018
dfbbfb7
child_process: allow typed arrays for input
SirR4T Aug 20, 2018
baf7dc5
fs: update read to work with any TypedArray/DataView
SirR4T Aug 6, 2018
b8ee669
doc: replace `1` by `process.stdout.fd`
starkwang Aug 28, 2018
6465623
crypto: add support for OCB mode for AEAD
tniessen Jun 14, 2018
a972159
test: move AEAD test vectors out of script
tniessen Jul 18, 2018
efeba2f
deps: sync V8 embedder string with master branch
targos Aug 28, 2018
76806e9
deps: backport StackFrame::GetFrame with isolate
targos Aug 26, 2018
9efa76f
src: use StackFrame::GetFrame with isolate
targos Aug 26, 2018
9140edf
deps: backport String::Write{OneByte,Utf8} with isolate
targos Aug 26, 2018
f576425
src: use String::Write{OneByte,Utf8} with isolate
targos Aug 26, 2018
83343f7
deps: backport String::Utf8Length with isolate
targos Aug 26, 2018
12f5480
src: use String::Utf8Length with isolate
targos Aug 26, 2018
ca2dd8c
doc: remove redundant 'Example:' and similar notes
vsemozhetbyt Aug 26, 2018
a0bab89
vm: add bindings for v8::CompileFunctionInContext
ryzokuken Jun 28, 2018
27e5286
test: refacor spawn[Sync]Pwd
refack Aug 25, 2018
6027f42
tools: Include links to source code in documentation
rubys Aug 19, 2018
2858896
doc: unify deprecation wording
tniessen Aug 27, 2018
35c7105
doc: make Stability Index more concise
Trott Aug 27, 2018
acaa918
test: fix typo in test name
Trott Aug 30, 2018
4b1685f
src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction
targos Aug 30, 2018
4dfbd91
doc: update Linux perf test status in our CI
Aug 29, 2018
f0cec23
doc: add profiling APIs to the diagnostics support document
Aug 29, 2018
fbf34d0
win,build: build N-API addons in parallel
bzoz Aug 29, 2018
45eb97e
child_process: fix handling of incorrect uid/gid in spawn
lundibundi Aug 28, 2018
e060fd7
crypto: deduplicate public key parsing
tniessen Aug 5, 2018
de985e8
build: use `0o` octal notation in configure
addaleax Aug 26, 2018
2d6ca80
test: move test that depends on dns query to internet
joyeecheung Aug 25, 2018
2a83628
doc: fix up warning text about character devices
addaleax Aug 28, 2018
b3e4a53
tools: specify rules disabled in common/dns.js
Trott Aug 28, 2018
6df8426
tools: specify rule disabled in test-assert.js
Trott Aug 28, 2018
21068d1
doc: add section on how to build debug build
tlbdk Aug 24, 2018
cf1a020
n-api: clean up thread-safe function
Aug 11, 2018
684f9e5
src: remove calls to deprecated v8 functions (BooleanValue)
ryzokuken Aug 1, 2018
021b704
doc: Remove 'dnt_helper.js'
Aug 30, 2018
f918e36
src: fix external memory usage going negative
mafintosh Aug 30, 2018
dfde87a
benchmark: add lines to scatter plots
lundibundi Aug 1, 2018
f0208b3
doc: clarify fallback behavior of module require
TomCoded Aug 22, 2018
0086ba6
test: improve assertions in test-cli-node-print-help
addaleax Aug 23, 2018
34ffb06
crypto: improve setAuthTag
tniessen Aug 26, 2018
e39d692
crypto: fix incorrect use of INT_MAX in validation
tniessen Aug 29, 2018
b9c0d5e
win, build: remove superfluous error message
bzoz Aug 29, 2018
ee237e3
src: remove calls to deprecated v8 functions (ToString)
ryzokuken Aug 29, 2018
3f9186e
src: rework (mostly internal) functions to use Maybes
ryzokuken Aug 29, 2018
3f35e88
tools: add [src] links to assert.html
rubys Aug 30, 2018
b50f3cc
src: remove calls to deprecated v8 functions (Uint32Value)
ryzokuken Aug 29, 2018
da1f78c
src: deprecate option variables in public API
addaleax Aug 24, 2018
b232606
doc: fix a typo in fs.md
vsemozhetbyt Aug 31, 2018
a1f57f4
doc: improve examples in buffer docs
pranshuchittora Aug 7, 2018
2a88731
lib: merge onread handlers for http2 streams & net.Socket
aks- May 5, 2018
68f7f87
doc: remove _optional_ designation for tls options
Trott Aug 27, 2018
672f74e
doc: indicate createSecureContext arg is optional
Trott Aug 27, 2018
6924d3d
src: fix node::FatalException
tniessen Sep 2, 2018
9257b55
test: use module.exports consistently
jasnell Aug 27, 2018
b0ea867
src: make CLI options programatically accesible
addaleax Aug 23, 2018
cab8a0b
cli: generate --help text in JS
addaleax Aug 23, 2018
6d6db60
deps: upgrade npm to 6.4.1
zkat Aug 29, 2018
c52d67b
src: add trace points to dns
chinhuang007 Jul 10, 2018
caaeceb
src: add `NODE_EXTERN` to class definition
addaleax Aug 27, 2018
68b0f49
src: disable debug options when inspector is unavailable
addaleax Sep 2, 2018
70d4039
build: use arm64 as DESTCPU for aarch64
danbev Aug 27, 2018
ec670b8
stream: update emit readable debug statement
danbev Aug 31, 2018
d8fff06
src: fix a typo in the comment
gireeshpunathil Sep 1, 2018
19633b0
doc: improve ECDH example
tniessen Sep 3, 2018
8efbda0
test: fix flaky parallel/test-fs-write-file-typedarrays
addaleax Sep 2, 2018
5b8a232
os: don't use getCheckedFunction() in userInfo()
cjihrig Aug 30, 2018
73e32ca
doc: add personal pronoun for danbev
danbev Sep 3, 2018
e761c40
doc: update a link in v8.md
lakamsani Aug 31, 2018
c8cd90d
doc: clarify Readable paused/flowing!==object mode
cxw42 Aug 31, 2018
032d886
doc: add blurb about implications of ABI stability
Aug 24, 2018
131d7e8
test: fix test-trace-events-dns
Trott Sep 3, 2018
f354cf8
deps: backport 4 CPU profiler commits from upstream V8
psmarshall Jul 30, 2018
f493861
test: improve assertion in process test
addaleax Aug 31, 2018
071d19a
tls: improve debugging assertion
addaleax Aug 31, 2018
45388f7
src: warn about odd UTF-16 decoding function signature
addaleax Aug 31, 2018
79556e5
src: allow UTF-16 in generic StringBytes decode call
addaleax Aug 31, 2018
29d19fd
deps: fix V8 test regression
targos Sep 3, 2018
3531aa0
deps: cherry-pick bf5ea81 from upstream V8
ofrobots Aug 3, 2018
4c34302
test: add test to dynamic enablement of trace-events
ofrobots Aug 3, 2018
5e9ed6d
deps: backport a8f6869 from upstream V8
benjamn Aug 4, 2018
037906b
deps: cherry-pick 22116dd from upstream V8
laverdet Jul 29, 2018
b934add
build,win: remove unmatched `endlocal` statement
refack Aug 31, 2018
be7f8fc
assert: fix loose set and map comparison
BridgeAR Aug 23, 2018
3d6d137
src: remove editing leftovers from options help text
addaleax Aug 31, 2018
0bf4de9
cli: more flexible width when printing `--help`
addaleax Aug 31, 2018
f4a2ac7
src: skip warnings for our own deprecated APIs
addaleax Sep 2, 2018
6f14b96
deps: update to nghttp2 1.33.0
addaleax Sep 2, 2018
ed96c3c
worker: display MessagePort status in util.inspect()
addaleax Sep 2, 2018
8e4caf5
test: fix flaky test-worker-message-port-transfer-self
addaleax Sep 2, 2018
8792609
test: fix flaky async-hooks/test-callback-error
addaleax Sep 2, 2018
d626372
Revert "test: mark async-hooks/test-callback-error as flaky"
addaleax Sep 2, 2018
cb93719
test: refactor test-gc-tls-external-memory
addaleax Sep 2, 2018
865180f
tools: add [src] links to async_hooks.html
rubys Sep 2, 2018
015a17f
http2: don't expose the original socket through the socket proxy
szmarczak Sep 2, 2018
416cfea
src: remove calls to deprecated V8 functions (Int32Value)
targos Sep 2, 2018
8b3b973
src: promote v8 name spaces with using
gireeshpunathil Sep 1, 2018
2555cb4
src: remove calls to deprecated v8 functions (IntegerValue)
ryzokuken Aug 29, 2018
f7daf6b
doc: remove usage of deprecated V8 APIs in addons.md
targos Sep 2, 2018
dd8e007
src: remove calls to deprecated V8 functions (Equals)
targos Sep 2, 2018
707a37f
coverage: expose native V8 coverage
Sep 5, 2018
8e542ea
zlib: fix memory leak for invalid input
addaleax Sep 5, 2018
cdb3598
2018-09-06, Version 10.10.0 (Current)
targos Sep 3, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .eslintrc.js
Expand Up @@ -187,7 +187,7 @@ module.exports = {
message: 'Use new keyword when throwing an Error.',
}
],
/* eslint-enable max-len, quotes */
/* eslint-enable max-len */
'no-return-await': 'error',
'no-self-assign': 'error',
'no-self-compare': 'error',
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Expand Up @@ -110,6 +110,9 @@ deps/npm/node_modules/.bin/
# api docs artifacts
tools/doc/node_modules

# clang-format artifacts
tools/clang-format/node_modules

# test artifacts
tools/remark-cli/node_modules
tools/remark-preset-lint-node/node_modules
Expand Down
21 changes: 12 additions & 9 deletions .travis.yml
Expand Up @@ -3,21 +3,24 @@ compiler:
- clang
sudo: false
cache: ccache
os: linux
matrix:
include:
- os: linux
- name: "Linter"
node_js: "latest"
env:
- NODE=$(which node)
install:
- NODE=$(which node) make lint-md-build
- make lint-md-build
script:
- NODE=$(which node) make lint-ci
- os: linux
- make lint
- name: "Test Suite"
install:
- ./configure
- make -j2 V=
script:
- make -j2 test-ci
before_install:
- export CXX="ccache clang++ -Qunused-arguments"
- export CC="ccache clang -Qunused-arguments -Wno-unknown-warning-option"
- export JOBS=2
- make -j2 test
before_install:
- export CXX="ccache clang++ -Qunused-arguments"
- export CC="ccache clang -Qunused-arguments -Wno-unknown-warning-option"
- export JOBS=2
91 changes: 66 additions & 25 deletions BUILDING.md
Expand Up @@ -42,16 +42,16 @@ platforms in production.
| GNU/Linux | Tier 1 | kernel >= 2.6.32, glibc >= 2.12 | x64, arm | |
| GNU/Linux | Tier 1 | kernel >= 3.10, glibc >= 2.17 | arm64 | |
| macOS/OS X | Tier 1 | >= 10.11 | x64 | |
| Windows | Tier 1 | >= Windows 7/2008 R2/2012 R2 | x86, x64 | vs2017 |
| SmartOS | Tier 2 | >= 15 < 16.4 | x86, x64 | see note1 |
| Windows | Tier 1 | >= Windows 7/2008 R2/2012 R2 | x86, x64 | [2](#fn2),[3](#fn3),[4](#fn4) |
| SmartOS | Tier 2 | >= 15 < 16.4 | x86, x64 | [1](#fn1) |
| FreeBSD | Tier 2 | >= 10 | x64 | |
| GNU/Linux | Tier 2 | kernel >= 3.13.0, glibc >= 2.19 | ppc64le >=power8 | |
| AIX | Tier 2 | >= 7.1 TL04 | ppc64be >=power7 | |
| GNU/Linux | Tier 2 | kernel >= 3.10, glibc >= 2.17 | s390x | |
| GNU/Linux | Experimental | kernel >= 2.6.32, glibc >= 2.12 | x86 | limited CI |
| Linux (musl) | Experimental | musl >= 1.0 | x64 | |

note1 - The gcc4.8-libs package needs to be installed, because node
<em id="fn1">1</em>: The gcc4.8-libs package needs to be installed, because node
binaries have been built with GCC 4.8, for which runtime libraries are not
installed by default. For these node versions, the recommended binaries
are the ones available in pkgsrc, not the one available from nodejs.org.
Expand All @@ -60,19 +60,22 @@ note1 - The gcc4.8-libs package needs to be installed, because node
by Joyent. SmartOS images >= 16.4 are not supported because
GCC 4.8 runtime libraries are not available in their pkgsrc repository

*Note*: On Windows, running Node.js in windows terminal emulators like `mintty`
requires the usage of [winpty](https://github.com/rprichard/winpty) for
Node's tty channels to work correctly (e.g. `winpty node.exe script.js`).
<em id="fn2">2</em>: Tier 1 support for building on Windows is only on 64 bit
hosts. Support is experimental for 32 bit hosts.

<em id="fn3">3</em>: On Windows, running Node.js in Windows terminal emulators
like `mintty` requires the usage of [winpty](https://github.com/rprichard/winpty)
for the tty channels to work correctly (e.g. `winpty node.exe script.js`).
In "Git bash" if you call the node shell alias (`node` without the `.exe`
extension), `winpty` is used automatically.

The Windows Subsystem for Linux (WSL) is not directly supported, but the
GNU/Linux build process and binaries should work. The community will only
address issues that reproduce on native GNU/Linux systems. Issues that only
reproduce on WSL should be reported in the
[WSL issue tracker](https://github.com/Microsoft/WSL/issues). Running the
Windows binary (`node.exe`) in WSL is not recommended, and will not work
without adjustment (such as stdio redirection).
<em id="fn4">4</em>: The Windows Subsystem for Linux (WSL) is not directly
supported, but the GNU/Linux build process and binaries should work. The
community will only address issues that reproduce on native GNU/Linux
systems. Issues that only reproduce on WSL should be reported in the
[WSL issue tracker](https://github.com/Microsoft/WSL/issues). Running the
Windows binary (`node.exe`) in WSL is not recommended, and will not work
without adjustment (such as stdio redirection).

### Supported toolchains

Expand All @@ -88,7 +91,7 @@ Depending on host platform, the selection of toolchains may vary.

#### Windows

* Visual Studio 2017 or the Build Tools thereof
* Visual Studio 2017 with the Windows 10 SDK on a 64 bit host.

#### OpenSSL asm support

Expand Down Expand Up @@ -132,17 +135,6 @@ More Developer Tools...`. This step will install `clang`, `clang++`, and
If the path to your build directory contains a space, the build will likely
fail.

After building, setting up [firewall rules](tools/macos-firewall.sh) can avoid
popups asking to accept incoming network connections when running tests.

Running the following script on macOS will add the firewall rules for the
executable `node` in the `out` directory and the symbolic `node` link in the
project's root directory.

```console
$ sudo ./tools/macos-firewall.sh
```

On FreeBSD and OpenBSD, you may also need:
* libexecinfo

Expand All @@ -166,6 +158,17 @@ for more information.
Note that the above requires that `python` resolve to Python 2.6 or 2.7
and not a newer version.

After building, setting up [firewall rules](tools/macos-firewall.sh) can avoid
popups asking to accept incoming network connections when running tests.

Running the following script on macOS will add the firewall rules for the
executable `node` in the `out` directory and the symbolic `node` link in the
project's root directory.

```console
$ sudo ./tools/macos-firewall.sh
```

#### Running Tests

To verify the build:
Expand Down Expand Up @@ -250,6 +253,44 @@ To install this version of Node.js into a system directory:
$ [sudo] make install
```

#### Building a debug build

If you run into an issue where the information provided by the JS stack trace
is not enough, or if you suspect the error happens outside of the JS VM, you
can try to build a debug enabled binary:

```console
$ ./configure --debug
$ make -j4
```

`make` with `./configure --debug` generates two binaries, the regular release
one in `out/Release/node` and a debug binary in `out/Debug/node`, only the
release version is actually installed when you run `make install`.

To use the debug build with all the normal dependencies overwrite the release
version in the install directory:

``` console
$ make install --prefix=/opt/node-debug/
$ cp -a -f out/Debug/node /opt/node-debug/node
```

When using the debug binary, core dumps will be generated in case of crashes.
These core dumps are useful for debugging when provided with the
corresponding original debug binary and system information.

Reading the core dump requires `gdb` built on the same platform the core dump
was captured on (i.e. 64 bit `gdb` for `node` built on a 64 bit system, Linux
`gdb` for `node` built on Linux) otherwise you will get errors like
`not in executable format: File format not recognized`.

Example of generating a backtrace from the core dump:

``` console
$ gdb /opt/node-debug/node core.node.8.1535359906
$ backtrace
```

### Windows

Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Expand Up @@ -31,7 +31,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V10.md#10.9.0">10.9.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V10.md#10.10.0">10.10.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V10.md#10.9.0">10.9.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V10.md#10.8.0">10.8.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V10.md#10.7.0">10.7.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V10.md#10.6.0">10.6.0</a><br/>
Expand Down
7 changes: 4 additions & 3 deletions COLLABORATOR_GUIDE.md
Expand Up @@ -65,9 +65,9 @@ badge.

For first-time contributors, check if the commit author is the same as the
pull request author, and ask if they have configured their git
username and email to their liking as per [this guide][git-username].
This is to make sure they would be promoted to "contributor" once
their pull request lands.
[username][git-username] and [email][git-email] to their liking.
This is to make sure they would be promoted to "contributor" once their
pull request lands.

### Closing Issues and Pull Requests

Expand Down Expand Up @@ -889,5 +889,6 @@ If you cannot find who to cc for a file, `git shortlog -n -s <file>` may help.
[git-node]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md
[git-node-metadata]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-metadata
[git-username]: https://help.github.com/articles/setting-your-username-in-git/
[git-email]: https://help.github.com/articles/setting-your-commit-email-address-in-git/
[node-core-utils-credentials]: https://github.com/nodejs/node-core-utils#setting-up-credentials
[node-core-utils-issues]: https://github.com/nodejs/node-core-utils/issues
2 changes: 1 addition & 1 deletion LICENSE
Expand Up @@ -53,7 +53,7 @@ The externally maintained libraries used by Node.js are:

- Acorn, located at deps/acorn, is licensed as follows:
"""
Copyright (C) 2012-2017 by various contributors (see AUTHORS)
Copyright (C) 2012-2018 by various contributors (see AUTHORS)

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down