[v8.x backport] doc: add and unify return statements in crypto.md

[trivikr]

Original PR #19853
Fixes #22853

Conform return statements to the style guide and tool parsers.

Also bring back a description fragment
that seems to be erroneously deleted in
1e07acd

PR-URL: #19853
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Gibson Fahnestock gibfahn@gmail.com
Reviewed-By: Trivikram Kamat trivikr.dev@gmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Tobias Nießen tniessen@tnie.de

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

@trivikr build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/892/pipeline

[vsemozhetbyt]

Thank you!

[vsemozhetbyt]

cc @nodejs/crypto

[trivikr]

I'm getting the following error while trying to land on v8.x-staging:

$ git node land 22870
⠹ Getting commits from nodejs/node/pull/22870{ Error: GraphQL request Error: Bad credentials
    at Request.query (/home/trivikr/.nvm/versions/node/v10.11.0/lib/node_modules/node-core-utils/lib/request.js:89:19)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  data:
   { variables: { after: null, prid: 22870, owner: 'nodejs', repo: 'node' } } }

Any idea what I could be doing wrong?

[MylesBorins]

@trivikr only members of the LTS team can land on LTS branches. It could also be due to the commit already having meta data and only needing the backport metadata

landed in 0340dd8

[richardlau]

@trivikr only members of the LTS team can land on LTS branches. It could also be due to the commit already having meta data and only needing the backport metadata

https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#how-are-lts-branches-managed says:

Any Collaborator may land commits into a staging branch, but only the release team should land commits into the LTS branch while preparing a new LTS release.

[trivikr]

Thanks @MylesBorins @richardlau
Can the message be improved in node-core-utils? It does say bad credentials which is good enough.