Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x backport] http: fix undefined error in parser event #22880

Closed
wants to merge 1 commit into from

Commits on Sep 15, 2018

  1. http: fix undefined error in parser event

    The current check for socket.server[kIncomingMessage] does not
    account for the possibility of a socket.server that doesn't
    have that property defined. Fix it.
    
    PR-URL: nodejs#20029
    Fixes: nodejs#19231
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    apapirovski authored and trivikr committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    a946051 View commit details
    Browse the repository at this point in the history