Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process,tty: allow reading/writing from duplex sockets #23053

Closed
wants to merge 7 commits into from
Closed

process,tty: allow reading/writing from duplex sockets #23053

wants to merge 7 commits into from

Commits on Sep 24, 2018

  1. Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READABLE" 

    This reverts commit 91eec00.

Refs: nodejs#21654
Refs: nodejs#21203
    @addaleax
    addaleax committed Sep 24, 2018
    Copy the full SHA
    a4e4e48 View commit details
    Browse the repository at this point in the history

  2. tools: allow input for TTY tests 

    Since faking TTY input is not otherwise fake-able, we need
support in the test runner for it.
    @addaleax
    addaleax committed Sep 24, 2018
    Copy the full SHA
    4467b66 View commit details
    Browse the repository at this point in the history

  3. process: allow reading from stdout/stderr sockets 

    Allow reading from stdio streams that are conventionally
associated with process output, since this is only convention.

This involves disabling the oddness around closing stdio
streams. Its purpose is to prevent the file descriptors
0 through 2 from being closed, since doing so can lead
to information leaks when new file descriptors are being
opened; instead, not doing anything seems like a more
reasonable choice.

Fixes: nodejs#21203
    @addaleax
    addaleax committed Sep 24, 2018
    Copy the full SHA
    dd5b960 View commit details
    Browse the repository at this point in the history

  4. test: add stdin writable regression test 

    Make sure that `process.stdin.write()`, and in particular
ending the stream, works.
    @addaleax
    addaleax committed Sep 24, 2018
    Copy the full SHA
    c39c8ac View commit details
    Browse the repository at this point in the history

  5. fixup! process: allow reading from stdout/stderr sockets

    @addaleax
    addaleax committed Sep 24, 2018
    Copy the full SHA
    5266788 View commit details
    Browse the repository at this point in the history

  6. fixup! Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READABLE"

    @addaleax
    addaleax committed Sep 24, 2018
    Copy the full SHA
    2fb5f00 View commit details
    Browse the repository at this point in the history

  7. fixup! fixup! Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READ… 

    …ABLE"
    @addaleax
    addaleax committed Sep 24, 2018
    Copy the full SHA
    df004fb View commit details
    Browse the repository at this point in the history