Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark some flakes #23208

Merged
merged 1 commit into from
Oct 2, 2018
Merged

test: mark some flakes #23208

merged 1 commit into from
Oct 2, 2018

Conversation

refack
Copy link
Contributor

@refack refack commented Oct 1, 2018 •
edited

parallel:

sequential:

and update some references

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@refack refack added test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 1, 2018
@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1093/pipeline

@refack
Copy link
Contributor Author

refack commented Oct 1, 2018

https://ci.nodejs.org/job/node-test-pull-request/17571/

/CC @nodejs/testing

If this passes CI I would like to fast-track. Please upvote if you approve.

@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
@refack
Copy link
Contributor Author

refack commented Oct 2, 2018 •
edited

Resume: https://ci.nodejs.org/job/node-test-pull-request/17587/
Rebuild: https://ci.nodejs.org/job/node-test-pull-request/17588/
Rebuild: https://ci.nodejs.org/job/node-test-pull-request/17589/

@refack
Copy link
Contributor Author

refack commented Oct 2, 2018

Ci shows 1 new arm flake test-http-end-throw-socket-handling #23221
But let's see how often it shows up

@refack
test: mark some flakes
1d56ad0 
PR-URL: nodejs#23208
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack refack merged commit 1d56ad0 into nodejs:master Oct 2, 2018
@refack
Copy link
Contributor Author

refack commented Oct 2, 2018

Fast-track landed in 1d56ad0 with 5 Approvals and 3 explicit up-votes.

@refack refack deleted the batch-of-flakes branch October 2, 2018 17:18
targos pushed a commit that referenced this pull request Oct 3, 2018
@refack @targos
test: mark some flakes
b2a1cf3 
PR-URL: #23208
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@refack @nodejs-github-bot @jasnell @addaleax @benjamingr @joyeecheung @BridgeAR