Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: remove duplicate async_hooks init for http parser #23263

Closed
wants to merge 2 commits into from
Closed

http: remove duplicate async_hooks init for http parser #23263

wants to merge 2 commits into from

Commits on Oct 4, 2018

  1. http: remove duplicate async_hooks init for http parser 

    Each time a new parser was created, AsyncReset was being called via
the C++ Parser class constructor (super constructor AsyncWrap) and also
via Parser::Reinitialize.

This also adds a missing async_hooks destroy event before AsyncReset is
called for the parser reuse case, otherwise the old async_id never gets
destroyed.

Refs: nodejs#19859
    @basti1302
    basti1302 committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    d46dc79 View commit details
    Browse the repository at this point in the history

  2. http: use symbol for FreeList's is_reused 

    This also at least keeps up the appearance of FreeList being a generic
all purpose thing (right now it is only used for HTTP parsers but
theoretically it could be used for any reusable resource). The
previous name "needsAsyncReset" implied a tight coupling to to async
resources, the new name "is_reused" is more generic.
    @basti1302
    basti1302 committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    26d1471 View commit details
    Browse the repository at this point in the history